Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-16823

Add Type_handler::Column_definition_reuse_fix_attributes()

Details

    Description

      The code in Column_definition::Column_definition(THD *thd, Field *old_field, Field *orig_field) has data-type specific fragments:

        switch (real_field_type()) {
      		 
        case MYSQL_TYPE_TINY_BLOB:
      		 
        case MYSQL_TYPE_BLOB:
      		 
        case MYSQL_TYPE_MEDIUM_BLOB:
      		 
        case MYSQL_TYPE_LONG_BLOB:
      		 
      ...

      This is not friendly to pluggable data types.

      We'll split this code into a new method in Type_handler:

      virtual void Column_definition_reuse_fix_attributes(THD *thd,
      		 
                                                          Column_definition *c,
      		 
                                                          const Field *field) const

      Attachments

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-4912 Data type plugin API version 1

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            issue.field.resolutiondate 2018-07-25 09:12:02.0 2018-07-25 09:12:02.257
            bar Alexander Barkov made changes -
            Fix Version/s 10.4.0 [ 23115 ]
            Fix Version/s 10.4 [ 22408 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 88579 ] MariaDB v4 [ 133636 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.