Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-16823

Add Type_handler::Column_definition_reuse_fix_attributes()

    Details

      Description

      The code in Column_definition::Column_definition(THD *thd, Field *old_field, Field *orig_field) has data-type specific fragments:

        switch (real_field_type()) {
        case MYSQL_TYPE_TINY_BLOB:
        case MYSQL_TYPE_BLOB:
        case MYSQL_TYPE_MEDIUM_BLOB:
        case MYSQL_TYPE_LONG_BLOB:
      ...
      

      This is not friendly to pluggable data types.

      We'll split this code into a new method in Type_handler:

      virtual void Column_definition_reuse_fix_attributes(THD *thd,
                                                          Column_definition *c,
                                                          const Field *field) const
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                bar Alexander Barkov
                Reporter:
                bar Alexander Barkov
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: