Type:
Task
Priority:
Major
Resolution:
Fixed
These methods:
longlong Item_func_between::val_int_cmp_temporal()
char *in_temporal::get_value_internal()
void cmp_item_temporal::store_value_internal()
use val_temporal_packed(field_type()) internally.
This is not friendly to new data types, e.g. it won't work for a new implementation for TIMESTAMP (needed for MDEV-15654 ) which transfers TIMESTAMP data inside the server using my_time_t representation rather than MYSQL_TIME representation.
This task is to remove Item::val_temporal_packed() and split implementations of the mentioned methods into separate methods for TIME and DATETIME:
longlong Item_func_between::val_int_cmp_time()
longlong Item_func_between::val_int_cmp_datetime()
uchar *in_datetime::get_value()
uchar *in_time::get_value()
void cmp_item_datetime::store_value()
void cmp_item_time::store_value()
These methods will use val_time_packed() and val_datetime_packed() directly.
blocks
MDEV-4912
Data type plugin API version 1
Closed
Transition
Time In Source Status
Execution Times
Open
Closed
6m 2s
1
{"report":{"fcp":818.8999999761581,"ttfb":250.10000002384186,"pageVisibility":"visible","entityId":68065,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"6f4f9b8a-fa82-4a50-a7b8-60db8dd78930","navigationType":0,"readyForUser":899.6999999284744,"redirectCount":0,"resourceLoadedEnd":925.5,"resourceLoadedStart":255.69999992847443,"resourceTiming":[{"duration":18.200000047683716,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":255.69999992847443,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":255.69999992847443,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":273.89999997615814,"responseStart":0,"secureConnectionStart":0},{"duration":18.299999952316284,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":256,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":256,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":274.2999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":95,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":256.10000002384186,"connectEnd":256.10000002384186,"connectStart":256.10000002384186,"domainLookupEnd":256.10000002384186,"domainLookupStart":256.10000002384186,"fetchStart":256.10000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":256.10000002384186,"responseEnd":351.10000002384186,"responseStart":351.10000002384186,"secureConnectionStart":256.10000002384186},{"duration":183.30000007152557,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":256.2999999523163,"connectEnd":256.2999999523163,"connectStart":256.2999999523163,"domainLookupEnd":256.2999999523163,"domainLookupStart":256.2999999523163,"fetchStart":256.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":256.2999999523163,"responseEnd":439.60000002384186,"responseStart":439.60000002384186,"secureConnectionStart":256.2999999523163},{"duration":186.89999997615814,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":256.60000002384186,"connectEnd":256.60000002384186,"connectStart":256.60000002384186,"domainLookupEnd":256.60000002384186,"domainLookupStart":256.60000002384186,"fetchStart":256.60000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":256.60000002384186,"responseEnd":443.5,"responseStart":443.5,"secureConnectionStart":256.60000002384186},{"duration":187.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":256.6999999284744,"connectEnd":256.6999999284744,"connectStart":256.6999999284744,"domainLookupEnd":256.6999999284744,"domainLookupStart":256.6999999284744,"fetchStart":256.6999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":256.6999999284744,"responseEnd":444.1999999284744,"responseStart":444.1999999284744,"secureConnectionStart":256.6999999284744},{"duration":187.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":257,"connectEnd":257,"connectStart":257,"domainLookupEnd":257,"domainLookupStart":257,"fetchStart":257,"redirectEnd":0,"redirectStart":0,"requestStart":257,"responseEnd":444.7999999523163,"responseStart":444.7999999523163,"secureConnectionStart":257},{"duration":239.10000002384186,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":257.1999999284744,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":257.1999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":496.2999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":188.20000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":257.2999999523163,"connectEnd":257.2999999523163,"connectStart":257.2999999523163,"domainLookupEnd":257.2999999523163,"domainLookupStart":257.2999999523163,"fetchStart":257.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":257.2999999523163,"responseEnd":445.5,"responseStart":445.5,"secureConnectionStart":257.2999999523163},{"duration":238.89999997615814,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":257.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":257.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":496.39999997615814,"responseStart":0,"secureConnectionStart":0},{"duration":188.60000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":257.6999999284744,"connectEnd":257.6999999284744,"connectStart":257.6999999284744,"domainLookupEnd":257.6999999284744,"domainLookupStart":257.6999999284744,"fetchStart":257.6999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":257.6999999284744,"responseEnd":446.2999999523163,"responseStart":446.2999999523163,"secureConnectionStart":257.6999999284744},{"duration":542.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":258.6999999284744,"connectEnd":258.6999999284744,"connectStart":258.6999999284744,"domainLookupEnd":258.6999999284744,"domainLookupStart":258.6999999284744,"fetchStart":258.6999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":258.6999999284744,"responseEnd":801.3999999761581,"responseStart":801.3999999761581,"secureConnectionStart":258.6999999284744},{"duration":641.8000000715256,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":258.7999999523163,"connectEnd":258.7999999523163,"connectStart":258.7999999523163,"domainLookupEnd":258.7999999523163,"domainLookupStart":258.7999999523163,"fetchStart":258.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":258.7999999523163,"responseEnd":900.6000000238419,"responseStart":900.5,"secureConnectionStart":258.7999999523163},{"duration":293.60000002384186,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":508.1999999284744,"connectEnd":508.1999999284744,"connectStart":508.1999999284744,"domainLookupEnd":508.1999999284744,"domainLookupStart":508.1999999284744,"fetchStart":508.1999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":508.1999999284744,"responseEnd":801.7999999523163,"responseStart":801.7999999523163,"secureConnectionStart":508.1999999284744},{"duration":173.39999997615814,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":812.3999999761581,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":812.3999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":985.7999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":89.79999995231628,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":835.6000000238419,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":835.6000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":925.3999999761581,"responseStart":0,"secureConnectionStart":0},{"duration":89.20000004768372,"initiatorType":"link","name":"https://jira.mariadb.org/s/50bc9be5bfead1a25e72c1a9338c94f6-CDN/lu2bu7/820016/12ta74/03ec8e95fb0700cf309083e2358eb54b/_/download/contextbatch/css/com.atlassian.jira.plugins.jira-development-integration-plugin:0,com.atlassian.jira.plugins.jira-quicksearch-plugin:5,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":836.2999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":836.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":925.5,"responseStart":0,"secureConnectionStart":0},{"duration":68.20000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":837.1999999284744,"connectEnd":837.1999999284744,"connectStart":837.1999999284744,"domainLookupEnd":837.1999999284744,"domainLookupStart":837.1999999284744,"fetchStart":837.1999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":837.1999999284744,"responseEnd":905.3999999761581,"responseStart":905.3999999761581,"secureConnectionStart":837.1999999284744},{"duration":75.20000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/f51ef5507eea4c158f257c66c93b2a3f-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":837.6999999284744,"connectEnd":837.6999999284744,"connectStart":837.6999999284744,"domainLookupEnd":837.6999999284744,"domainLookupStart":837.6999999284744,"fetchStart":837.6999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":837.6999999284744,"responseEnd":912.8999999761581,"responseStart":912.8999999761581,"secureConnectionStart":837.6999999284744},{"duration":76.20000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/0b63859f61e7b6c2acdd2eef749beab8-CDN/lu2bu7/820016/12ta74/03ec8e95fb0700cf309083e2358eb54b/_/download/contextbatch/js/com.atlassian.jira.plugins.jira-development-integration-plugin:0,com.atlassian.jira.plugins.jira-quicksearch-plugin:5,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":838.1999999284744,"connectEnd":838.1999999284744,"connectStart":838.1999999284744,"domainLookupEnd":838.1999999284744,"domainLookupStart":838.1999999284744,"fetchStart":838.1999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":838.1999999284744,"responseEnd":914.3999999761581,"responseStart":914.3999999761581,"secureConnectionStart":838.1999999284744}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":84,"responseStart":250,"responseEnd":251,"domLoading":254,"domInteractive":1036,"domContentLoadedEventStart":1036,"domContentLoadedEventEnd":1080,"domComplete":1303,"loadEventStart":1303,"loadEventEnd":1306,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":998.7999999523163},{"name":"bigPipe.sidebar-id.end","time":1000.2999999523163},{"name":"bigPipe.activity-panel-pipe-id.start","time":1000.6999999284744},{"name":"bigPipe.activity-panel-pipe-id.end","time":1001.6999999284744},{"name":"activityTabFullyLoaded","time":1096.6000000238419}],"measures":[],"correlationId":"a1d4068e97876a","effectiveType":"4g","downlink":9.8,"rtt":0,"serverDuration":104,"dbReadsTimeInMs":16,"dbConnsTimeInMs":26,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}