Type:
Task
Priority:
Major
Resolution:
Fixed
These methods:
longlong Item_func_between::val_int_cmp_temporal()
char *in_temporal::get_value_internal()
void cmp_item_temporal::store_value_internal()
use val_temporal_packed(field_type()) internally.
This is not friendly to new data types, e.g. it won't work for a new implementation for TIMESTAMP (needed for MDEV-15654 ) which transfers TIMESTAMP data inside the server using my_time_t representation rather than MYSQL_TIME representation.
This task is to remove Item::val_temporal_packed() and split implementations of the mentioned methods into separate methods for TIME and DATETIME:
longlong Item_func_between::val_int_cmp_time()
longlong Item_func_between::val_int_cmp_datetime()
uchar *in_datetime::get_value()
uchar *in_time::get_value()
void cmp_item_datetime::store_value()
void cmp_item_time::store_value()
These methods will use val_time_packed() and val_datetime_packed() directly.
blocks
MDEV-4912
Data type plugin API version 1
Closed
{"report":{"fcp":921.5999999046326,"ttfb":182.09999990463257,"pageVisibility":"visible","entityId":68065,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"1e201a0b-80f5-42e5-99c8-1ccd5c228e62","navigationType":0,"readyForUser":996.4000000953674,"redirectCount":0,"resourceLoadedEnd":1136.7000002861023,"resourceLoadedStart":187.59999990463257,"resourceTiming":[{"duration":253.7000002861023,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":187.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":187.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":441.30000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":253.7999997138977,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":187.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":187.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":441.59999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":262.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":188,"connectEnd":188,"connectStart":188,"domainLookupEnd":188,"domainLookupStart":188,"fetchStart":188,"redirectEnd":0,"redirectStart":0,"requestStart":188,"responseEnd":450.90000009536743,"responseStart":450.80000019073486,"secureConnectionStart":188},{"duration":313.2000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":188.09999990463257,"connectEnd":188.09999990463257,"connectStart":188.09999990463257,"domainLookupEnd":188.09999990463257,"domainLookupStart":188.09999990463257,"fetchStart":188.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":188.09999990463257,"responseEnd":501.30000019073486,"responseStart":501.30000019073486,"secureConnectionStart":188.09999990463257},{"duration":316.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":188.40000009536743,"connectEnd":188.40000009536743,"connectStart":188.40000009536743,"domainLookupEnd":188.40000009536743,"domainLookupStart":188.40000009536743,"fetchStart":188.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":188.40000009536743,"responseEnd":505.09999990463257,"responseStart":505.09999990463257,"secureConnectionStart":188.40000009536743},{"duration":317.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":188.5,"connectEnd":188.5,"connectStart":188.5,"domainLookupEnd":188.5,"domainLookupStart":188.5,"fetchStart":188.5,"redirectEnd":0,"redirectStart":0,"requestStart":188.5,"responseEnd":505.59999990463257,"responseStart":505.59999990463257,"secureConnectionStart":188.5},{"duration":317.3999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":188.7000002861023,"connectEnd":188.7000002861023,"connectStart":188.7000002861023,"domainLookupEnd":188.7000002861023,"domainLookupStart":188.7000002861023,"fetchStart":188.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":188.7000002861023,"responseEnd":506.09999990463257,"responseStart":506.09999990463257,"secureConnectionStart":188.7000002861023},{"duration":407.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":188.90000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":188.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":596.4000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":317.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":189.09999990463257,"connectEnd":189.09999990463257,"connectStart":189.09999990463257,"domainLookupEnd":189.09999990463257,"domainLookupStart":189.09999990463257,"fetchStart":189.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":189.09999990463257,"responseEnd":506.40000009536743,"responseStart":506.40000009536743,"secureConnectionStart":189.09999990463257},{"duration":407.3999996185303,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":189.2000002861023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":189.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":596.5999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":317.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":189.40000009536743,"connectEnd":189.40000009536743,"connectStart":189.40000009536743,"domainLookupEnd":189.40000009536743,"domainLookupStart":189.40000009536743,"fetchStart":189.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":189.40000009536743,"responseEnd":507.2000002861023,"responseStart":507.2000002861023,"secureConnectionStart":189.40000009536743},{"duration":658.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":190.2000002861023,"connectEnd":190.2000002861023,"connectStart":190.2000002861023,"domainLookupEnd":190.2000002861023,"domainLookupStart":190.2000002861023,"fetchStart":190.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":190.2000002861023,"responseEnd":848.7000002861023,"responseStart":848.7000002861023,"secureConnectionStart":190.2000002861023},{"duration":942.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":190.40000009536743,"connectEnd":190.40000009536743,"connectStart":190.40000009536743,"domainLookupEnd":190.40000009536743,"domainLookupStart":190.40000009536743,"fetchStart":190.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":190.40000009536743,"responseEnd":1132.8000001907349,"responseStart":1132.8000001907349,"secureConnectionStart":190.40000009536743},{"duration":244,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":608.3000001907349,"connectEnd":608.3000001907349,"connectStart":608.3000001907349,"domainLookupEnd":608.3000001907349,"domainLookupStart":608.3000001907349,"fetchStart":608.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":608.3000001907349,"responseEnd":852.3000001907349,"responseStart":852.3000001907349,"secureConnectionStart":608.3000001907349},{"duration":261.1000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":875.5999999046326,"connectEnd":875.5999999046326,"connectStart":875.5999999046326,"domainLookupEnd":875.5999999046326,"domainLookupStart":875.5999999046326,"fetchStart":875.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":875.5999999046326,"responseEnd":1136.7000002861023,"responseStart":1136.7000002861023,"secureConnectionStart":875.5999999046326},{"duration":242.30000019073486,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":915.4000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":915.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1157.7000002861023,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":38,"responseStart":182,"responseEnd":184,"domLoading":185,"domInteractive":1159,"domContentLoadedEventStart":1159,"domContentLoadedEventEnd":1199,"domComplete":2071,"loadEventStart":2071,"loadEventEnd":2072,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1135.2000002861023},{"name":"bigPipe.sidebar-id.end","time":1136},{"name":"bigPipe.activity-panel-pipe-id.start","time":1136.2000002861023},{"name":"bigPipe.activity-panel-pipe-id.end","time":1138.5999999046326},{"name":"activityTabFullyLoaded","time":1205.0999999046326}],"measures":[],"correlationId":"e1ada521ac2b61","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":86,"dbReadsTimeInMs":10,"dbConnsTimeInMs":18,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}