Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-16316

Replace INT_ITEM references in the code behind ORDER, LIMIT, PROCEDURE clause

Details

    Description

      This is a self-containing sub-task for MDEV-14630, to get rid of INT_ITEM references in the code specifically behind ORDER, LIMIT and PROCEDURE clauses.
      We'll replace the code testing Item::type() against ITEM_INT to new methods in Item and Type_handler.

      Some examples of the affected code:

      if (order_item->type() == Item::INT_ITEM && order_item->basic_const_item() &&
      		 
          !from_window_spec)


      if (item->type() != Item::INT_ITEM)
      		 
      {
      		 
        my_error(ER_WRONG_SPVAR_TYPE_IN_LIMIT, MYF(0));


      if (!(*param->item)->fixed && (*param->item)->fix_fields(thd, param->item))
      		 
      {
      		 
        DBUG_PRINT("info", ("fix_fields() for the first parameter failed"));
      		 
        goto err;
      		 
      }

      There are more similar pieces.

      Attachments

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-4912 Data type plugin API version 1

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. MDEV-14630 Replace {STRING|INT|REAL|DECIMAL|DATE}_ITEM to CONST_ITEM

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            issue.field.resolutiondate 2018-05-29 09:37:07.0 2018-05-29 09:37:07.772
            bar Alexander Barkov made changes -
            Fix Version/s 10.4.0 [ 23115 ]
            Fix Version/s 10.4 [ 22408 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            bar Alexander Barkov made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 87500 ] MariaDB v4 [ 133563 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.