Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15735

mariadb-10.2.14/storage/connect/filamtxt.cpp:429]: (style) Suspicious condition

Details

    Description

      mariadb-10.2.14/storage/connect/filamtxt.cpp:429]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

      Source code is

      if ((irc = InitDelete(g, Posar->GetIntValue(ix[i]),
      Sosar->GetIntValue(ix[i])) == RC_FX))

      Maybe better code

      if ((irc = InitDelete(g, Posar->GetIntValue(ix[i]),
      Sosar->GetIntValue(ix[i]))) == RC_FX)

      Attachments

        Activity

          Transition Time In Source Status Execution Times
          Olivier Bertrand made transition -
          Open In Progress
          		8d 21h 46m 1
          Olivier Bertrand made transition -
          In Progress Closed
          		32d 19h 27m 1

          People

            bertrandop Olivier Bertrand
            dcb David Binderman
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.