Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15735

mariadb-10.2.14/storage/connect/filamtxt.cpp:429]: (style) Suspicious condition

    XMLWordPrintable

    Details

      Description

      mariadb-10.2.14/storage/connect/filamtxt.cpp:429]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

      Source code is

      if ((irc = InitDelete(g, Posar->GetIntValue(ix[i]),
      Sosar->GetIntValue(ix[i])) == RC_FX))

      Maybe better code

      if ((irc = InitDelete(g, Posar->GetIntValue(ix[i]),
      Sosar->GetIntValue(ix[i]))) == RC_FX)

        Attachments

          Activity

            People

            Assignee:
            bertrandop Olivier Bertrand
            Reporter:
            dcb David Binderman
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: