[MDEV-15735] mariadb-10.2.14/storage/connect/filamtxt.cpp:429]: (style) Suspicious condition - Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Minor
Resolution: Fixed
Affects Version/s: 10.2(EOL)
Fix Version/s: 10.0.36, 10.1.34, 10.2.15, 10.3.7
Component/s: Storage Engine - Connect
Labels:
- beginner-friendly

Description

mariadb-10.2.14/storage/connect/filamtxt.cpp:429]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

if ((irc = InitDelete(g, Posar->GetIntValue(ix[i]),
Sosar->GetIntValue(ix[i])) == RC_FX))

Maybe better code

if ((irc = InitDelete(g, Posar->GetIntValue(ix[i]),
Sosar->GetIntValue(ix[i]))) == RC_FX)

Attachments

Activity

People

Assignee:: Olivier Bertrand

Reporter:: David Binderman

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2018-03-29 16:08

Updated:: 2018-10-28 09:41

Resolved:: 2018-05-10 09:21

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.