[#MDEV-15735] mariadb-10.2.14/storage/connect/filamtxt.cpp:429]: (style) Suspicious condition

[MDEV-15735] mariadb-10.2.14/storage/connect/filamtxt.cpp:429]: (style) Suspicious condition Created: 2018-03-29 Updated: 2018-10-28 Resolved: 2018-05-10
Status:	Closed
Project:	MariaDB Server
Component/s:	Storage Engine - Connect
Affects Version/s:	10.2
Fix Version/s:	10.0.36, 10.1.34, 10.2.15, 10.3.7

Type:

Bug

Priority:

Minor

Reporter:

David Binderman

Assignee:

Olivier Bertrand

Resolution:

Fixed

Votes:

Labels:

beginner-friendly

Description

mariadb-10.2.14/storage/connect/filamtxt.cpp:429]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

if ((irc = InitDelete(g, Posar->GetIntValue(ix[i]),
Sosar->GetIntValue(ix[i])) == RC_FX))

Maybe better code

if ((irc = InitDelete(g, Posar->GetIntValue(ix[i]),
Sosar->GetIntValue(ix[i]))) == RC_FX)

Comments

Comment by Olivier Bertrand [ 2018-05-10 ]

Thanks for reporting. Your solution was applied.

Generated at Thu Feb 08 08:23:37 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.