Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15735

mariadb-10.2.14/storage/connect/filamtxt.cpp:429]: (style) Suspicious condition

Details

    Description

      mariadb-10.2.14/storage/connect/filamtxt.cpp:429]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

      Source code is

      if ((irc = InitDelete(g, Posar->GetIntValue(ix[i]),
      Sosar->GetIntValue(ix[i])) == RC_FX))

      Maybe better code

      if ((irc = InitDelete(g, Posar->GetIntValue(ix[i]),
      Sosar->GetIntValue(ix[i]))) == RC_FX)

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          dcb David Binderman created issue -
          serg Sergei Golubchik made changes -
          Field Original Value New Value
          Labels beginner-friendly
          serg Sergei Golubchik made changes -
          Key MAC-56 MDEV-15735
          Workflow MariaDB ColumnStore workflow [ 86302 ] MariaDB v3 [ 86309 ]
          Project MariaDB Administrative Console [ 11101 ] MariaDB Server [ 10000 ]
          elenst Elena Stepanova made changes -
          Component/s Storage Engine - Connect [ 10128 ]
          Fix Version/s 10.2 [ 14601 ]
          Affects Version/s 10.2 [ 14601 ]
          Assignee Olivier Bertrand [ bertrandop ]
          bertrandop Olivier Bertrand made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          bertrandop Olivier Bertrand made changes -
          issue.field.resolutiondate 2018-05-10 09:21:37.0 2018-05-10 09:21:37.408
          bertrandop Olivier Bertrand made changes -
          Fix Version/s 10.0.36 [ 22916 ]
          Fix Version/s 10.1.34 [ 23100 ]
          Fix Version/s 10.2.15 [ 23006 ]
          Fix Version/s 10.3.7 [ 23005 ]
          Fix Version/s 10.2 [ 14601 ]
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Closed [ 6 ]
          bertrandop Olivier Bertrand added a comment -

          Thanks for reporting. Your solution was applied.

          bertrandop Olivier Bertrand added a comment - Thanks for reporting. Your solution was applied.
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 86309 ] MariaDB v4 [ 154059 ]

          People

            bertrandop Olivier Bertrand
            dcb David Binderman
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.