Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15734

mariadb-10.2.14/storage/tokudb/PerconaFT/ft/logger/logger.cc:675: suspicious expression ?

Details

    Description

      mariadb-10.2.14/storage/tokudb/PerconaFT/ft/logger/logger.cc:675]: (warning) Found calculation inside sizeof().

      Source code is

      int width = sizeof(result[0]+2);

      Maybe better code

      int width = sizeof(result[0])+2;

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          elenst Elena Stepanova added a comment -

          serg, you've set it to "beginner-friendly", do you want it to be fixed on MariaDB side?

          elenst Elena Stepanova added a comment - serg , you've set it to "beginner-friendly", do you want it to be fixed on MariaDB side?
          serg Sergei Golubchik added a comment -

          No, not necessarily. It'll be better if Percona fixes it, of course.

          serg Sergei Golubchik added a comment - No, not necessarily. It'll be better if Percona fixes it, of course.
          elenst Elena Stepanova added a comment -

          dcb, did you happen to report it to Percona?

          I don't know though how much chance there is to have it fixed, since Percona has deprecated support of TokuDB.

          elenst Elena Stepanova added a comment - dcb , did you happen to report it to Percona? I don't know though how much chance there is to have it fixed, since Percona has deprecated support of TokuDB .
          dawson Suyang Chen added a comment -

          Hey, I would like to solve this issue as my first newcomer issue. Can anyone guide me how to contribute? Thanks in advance.

          dawson Suyang Chen added a comment - Hey, I would like to solve this issue as my first newcomer issue. Can anyone guide me how to contribute? Thanks in advance.
          serg Sergei Golubchik added a comment -

          Hi, dawson. See https://mariadb.org/get-involved/getting-started-for-developers/

          serg Sergei Golubchik added a comment - Hi, dawson . See https://mariadb.org/get-involved/getting-started-for-developers/
          ccalender Chris Calender (Inactive) added a comment -

          Closing in on a year, so I just went ahead and fixed this:

          https://github.com/MariaDB/server/pull/1169

          ccalender Chris Calender (Inactive) added a comment - Closing in on a year, so I just went ahead and fixed this: https://github.com/MariaDB/server/pull/1169
          svoj Sergey Vojtovich added a comment -

          PerconaFT PR re-submitted by Daniel Black: https://github.com/percona/PerconaFT/pull/425

          svoj Sergey Vojtovich added a comment - PerconaFT PR re-submitted by Daniel Black: https://github.com/percona/PerconaFT/pull/425

          People

            svoj Sergey Vojtovich
            dcb David Binderman
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.