[MDEV-15734] mariadb-10.2.14/storage/tokudb/PerconaFT/ft/logger/logger.cc:675: suspicious expression ? Created: 2018-03-29 Updated: 2019-05-30 Resolved: 2019-05-30 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - TokuDB |
| Affects Version/s: | 10.2 |
| Fix Version/s: | 10.2.25, 10.1.41, 10.3.16, 10.4.6 |
| Type: | Bug | Priority: | Minor |
| Reporter: | David Binderman | Assignee: | Sergey Vojtovich |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | beginner-friendly, upstream | ||
| Description |
|
mariadb-10.2.14/storage/tokudb/PerconaFT/ft/logger/logger.cc:675]: (warning) Found calculation inside sizeof(). Source code is int width = sizeof(result[0]+2); Maybe better code int width = sizeof(result[0])+2; |
| Comments |
| Comment by Elena Stepanova [ 2018-10-04 ] |
|
serg, you've set it to "beginner-friendly", do you want it to be fixed on MariaDB side? |
| Comment by Sergei Golubchik [ 2018-10-16 ] |
|
No, not necessarily. It'll be better if Percona fixes it, of course. |
| Comment by Elena Stepanova [ 2018-12-31 ] |
|
dcb, did you happen to report it to Percona? I don't know though how much chance there is to have it fixed, since Percona has deprecated support of TokuDB. |
| Comment by Suyang Chen [ 2019-01-07 ] |
|
Hey, I would like to solve this issue as my first newcomer issue. Can anyone guide me how to contribute? Thanks in advance. |
| Comment by Sergei Golubchik [ 2019-01-23 ] |
|
Hi, dawson. See https://mariadb.org/get-involved/getting-started-for-developers/ |
| Comment by Chris Calender (Inactive) [ 2019-02-08 ] |
|
Closing in on a year, so I just went ahead and fixed this: |
| Comment by Sergey Vojtovich [ 2019-05-30 ] |
|
PerconaFT PR re-submitted by Daniel Black: https://github.com/percona/PerconaFT/pull/425 |