The function ha_innobase::check_if_supported_inplace_alter() refuses ALGORITHM=INPLACE operation if innodb_force_recovery has been specified. This is unnecessarily strict; only the values 4,5,6 will effectively corrupt the database and require any writes to be blocked. In MariaDB 10.2 we have the flag high_level_read_only that should be used instead.
Furthermore, the high_level_read_only flag should be set if newraw was specified for the InnoDB system tablespace.
I noticed this during the MDEV-13134 code review.
- relates to
-
MDEV-13134
Introduce ALTER TABLE attributes ALGORITHM=NOCOPY and ALGORITHM=INSTANT
-
-
Closed
{"report":{"fcp":895.6000001430511,"ttfb":367.80000019073486,"pageVisibility":"visible","entityId":66586,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"e3348805-d918-4045-8fbb-81d369db807d","navigationType":0,"readyForUser":949,"redirectCount":0,"resourceLoadedEnd":963.1000001430511,"resourceLoadedStart":373.5,"resourceTiming":[{"duration":9.200000047683716,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":373.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":373.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":382.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":9.599999904632568,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":373.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":373.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":383.40000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":61,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":374,"connectEnd":374,"connectStart":374,"domainLookupEnd":374,"domainLookupStart":374,"fetchStart":374,"redirectEnd":0,"redirectStart":0,"requestStart":374,"responseEnd":435,"responseStart":435,"secureConnectionStart":374},{"duration":131.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":374.10000014305115,"connectEnd":374.10000014305115,"connectStart":374.10000014305115,"domainLookupEnd":374.10000014305115,"domainLookupStart":374.10000014305115,"fetchStart":374.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":374.10000014305115,"responseEnd":505.2000000476837,"responseStart":505.2000000476837,"secureConnectionStart":374.10000014305115},{"duration":134.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":374.2000000476837,"connectEnd":374.2000000476837,"connectStart":374.2000000476837,"domainLookupEnd":374.2000000476837,"domainLookupStart":374.2000000476837,"fetchStart":374.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":374.2000000476837,"responseEnd":508.90000009536743,"responseStart":508.90000009536743,"secureConnectionStart":374.2000000476837},{"duration":135.29999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":374.2000000476837,"connectEnd":374.2000000476837,"connectStart":374.2000000476837,"domainLookupEnd":374.2000000476837,"domainLookupStart":374.2000000476837,"fetchStart":374.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":374.2000000476837,"responseEnd":509.5,"responseStart":509.5,"secureConnectionStart":374.2000000476837},{"duration":135.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":374.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":374.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":510.30000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":135.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":374.40000009536743,"connectEnd":374.40000009536743,"connectStart":374.40000009536743,"domainLookupEnd":374.40000009536743,"domainLookupStart":374.40000009536743,"fetchStart":374.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":374.40000009536743,"responseEnd":509.90000009536743,"responseStart":509.90000009536743,"secureConnectionStart":374.40000009536743},{"duration":135.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":374.60000014305115,"connectEnd":374.60000014305115,"connectStart":374.60000014305115,"domainLookupEnd":374.60000014305115,"domainLookupStart":374.60000014305115,"fetchStart":374.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":374.60000014305115,"responseEnd":510.30000019073486,"responseStart":510.30000019073486,"secureConnectionStart":374.60000014305115},{"duration":136,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":374.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":374.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":510.80000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":136.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":374.80000019073486,"connectEnd":374.80000019073486,"connectStart":374.80000019073486,"domainLookupEnd":374.80000019073486,"domainLookupStart":374.80000019073486,"fetchStart":374.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":374.80000019073486,"responseEnd":510.90000009536743,"responseStart":510.90000009536743,"secureConnectionStart":374.80000019073486},{"duration":331.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":375.60000014305115,"connectEnd":375.60000014305115,"connectStart":375.60000014305115,"domainLookupEnd":375.60000014305115,"domainLookupStart":375.60000014305115,"fetchStart":375.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":375.60000014305115,"responseEnd":707.1000001430511,"responseStart":707.1000001430511,"secureConnectionStart":375.60000014305115},{"duration":456.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":380.2000000476837,"connectEnd":380.2000000476837,"connectStart":380.2000000476837,"domainLookupEnd":380.2000000476837,"domainLookupStart":380.2000000476837,"fetchStart":380.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":380.2000000476837,"responseEnd":837.1000001430511,"responseStart":837.1000001430511,"secureConnectionStart":380.2000000476837},{"duration":137.69999980926514,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":647.8000001907349,"connectEnd":647.8000001907349,"connectStart":647.8000001907349,"domainLookupEnd":647.8000001907349,"domainLookupStart":647.8000001907349,"fetchStart":647.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":647.8000001907349,"responseEnd":785.5,"responseStart":785.5,"secureConnectionStart":647.8000001907349},{"duration":93.09999990463257,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":869.8000001907349,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":869.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":962.9000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":89.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":873.6000001430511,"connectEnd":873.6000001430511,"connectStart":873.6000001430511,"domainLookupEnd":873.6000001430511,"domainLookupStart":873.6000001430511,"fetchStart":873.6000001430511,"redirectEnd":0,"redirectStart":0,"requestStart":873.6000001430511,"responseEnd":963.1000001430511,"responseStart":963.1000001430511,"secureConnectionStart":873.6000001430511}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":253,"responseStart":367,"responseEnd":372,"domLoading":371,"domInteractive":999,"domContentLoadedEventStart":999,"domContentLoadedEventEnd":1031,"domComplete":1753,"loadEventStart":1753,"loadEventEnd":1753,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":979.5},{"name":"bigPipe.sidebar-id.end","time":980.3000001907349},{"name":"bigPipe.activity-panel-pipe-id.start","time":980.5},{"name":"bigPipe.activity-panel-pipe-id.end","time":982.8000001907349},{"name":"activityTabFullyLoaded","time":1039.2000000476837}],"measures":[],"correlationId":"513dd70227a196","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":69,"dbReadsTimeInMs":13,"dbConnsTimeInMs":20,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Bug
Minor