Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15719

ALTER TABLE…ALGORITHM=INPLACE is unnecessarily refused due to innodb_force_recovery

Details

    Description

      The function ha_innobase::check_if_supported_inplace_alter() refuses ALGORITHM=INPLACE operation if innodb_force_recovery has been specified. This is unnecessarily strict; only the values 4,5,6 will effectively corrupt the database and require any writes to be blocked. In MariaDB 10.2 we have the flag high_level_read_only that should be used instead.

      Furthermore, the high_level_read_only flag should be set if newraw was specified for the InnoDB system tablespace.

      I noticed this during the MDEV-13134 code review.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-13134 Introduce ALTER TABLE attributes ALGORITHM=NOCOPY and ALGORITHM=INSTANT

          • Major - Major loss of function.
          • Closed

          Activity

            Transition Time In Source Status Execution Times
            Marko Mäkelä made transition -
            Open Closed
            		15m 39s 1

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.