Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15522

Change galera suite MTR tests to use mariabackup instead of xtrabackup

Details

    Description

      Galera MTR suite has following tests, which are configured to use xtrabackup as SST method:
      galera_autoinc_sst_xtrabackup
      galera_ist_innodb_flush_logs
      galera_ist_xtrabackup-v2
      galera_sst_xtrabackup-v2-options
      galera_sst_xtrabackup-v2_encrypt_with_key

      And there are no tests using mariabackup, at the moment.

      Starting from MariaDB 10.2, xtrabackup (version 2.4) does not work with the reviced redo log format. Therefore it is substantial to either add mariabackup as option for SST or to change all SST tests to use mariabackup instead of xtrabackup.

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. MDEV-13549 Galera 3 test failures

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is blocked by

          Task - A task that needs to be done. MDEV-17771 Add Galera ist and sst tests using mariabackup

          • Major - Major loss of function.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-11369 Instant add column for InnoDB

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-12288 Reset DB_TRX_ID when the history is removed, to speed up MVCC

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12289 Keep 128 persistent rollback segments for compatibility and performance

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-12548 Add maria backup tool to MariaDB 10.2

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-13564 TRUNCATE TABLE and undo tablespace truncation are not compatible with Mariabackup

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-17304 Replace use of XtraBackup with MariaDB Backup

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-17835 Remove wsrep-sst-method=xtrabackup

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            svoj Sergey Vojtovich added a comment -

            jplindst, please review https://github.com/MariaDB/server/pull/648

            svoj Sergey Vojtovich added a comment - jplindst , please review https://github.com/MariaDB/server/pull/648
            marko Marko Mäkelä added a comment -

            Percona Xtrabackup may be unsafe to use with MariaDB 10.2, because it may process undo log records in a way that is incompatible with the changes implemented in MDEV-12289 (to maintain undo log compatibility with older versions of MariaDB and MySQL up to 5.6).

            Xtrabackup cannot possibly work with the new redo log format introduced in MariaDB 10.3 for MDEV-12288 and MDEV-11369. It also never worked with innodb_encrypt_log. While we are at this, maybe the transfer of encrypted InnoDB data and log files should be covered by tests?

            marko Marko Mäkelä added a comment - Percona Xtrabackup may be unsafe to use with MariaDB 10.2, because it may process undo log records in a way that is incompatible with the changes implemented in MDEV-12289 (to maintain undo log compatibility with older versions of MariaDB and MySQL up to 5.6). Xtrabackup cannot possibly work with the new redo log format introduced in MariaDB 10.3 for MDEV-12288 and MDEV-11369 . It also never worked with innodb_encrypt_log . While we are at this, maybe the transfer of encrypted InnoDB data and log files should be covered by tests?
            jplindst Jan Lindström (Inactive) added a comment -

            winstone Could you start by applying the pull request and then try to fix the actual test cases one by one to get this issue fixed ?

            jplindst Jan Lindström (Inactive) added a comment - winstone Could you start by applying the pull request and then try to fix the actual test cases one by one to get this issue fixed ?
            marko Marko Mäkelä added a comment -

            As far as I can tell, the pull request does not replace references to xtrabackup or innobackupex in scripts/wsrep_sst_xtrabackup*. In fact, it does not touch those scripts at all. I do not think that those scripts have any reason to exist in MariaDB 10.2+.

            marko Marko Mäkelä added a comment - As far as I can tell, the pull request does not replace references to xtrabackup or innobackupex in scripts/wsrep_sst_xtrabackup* . In fact, it does not touch those scripts at all. I do not think that those scripts have any reason to exist in MariaDB 10.2+.
            winstone Zdravelina Sokolovska (Inactive) added a comment - - edited

            in my opinion it is more appropriate to update galera test suite MTR with separate mariabackup tests , instead of change the available MTR xtrabackup,xtrabackup-v2 tests — refer to MDEV-16018, as well MDEV-16019

            winstone Zdravelina Sokolovska (Inactive) added a comment - - edited in my opinion it is more appropriate to update galera test suite MTR with separate mariabackup tests , instead of change the available MTR xtrabackup,xtrabackup-v2 tests — refer to MDEV-16018 , as well MDEV-16019
            marko Marko Mäkelä added a comment -

            I think that we have no other choice than to remove the xtrabackup scripts from 10.2, because the crash-downgrade prevention in MDEV-13564 (which is planned to be pushed to 10.2) will prevent xtrabackup from working at all. It changes the InnoDB redo log format tag, which will prevent older 10.2 versions from doing crash-downgrade (or versions before MDEV-14909, even a downgrade after clean shutdown).

            marko Marko Mäkelä added a comment - I think that we have no other choice than to remove the xtrabackup scripts from 10.2, because the crash-downgrade prevention in MDEV-13564 (which is planned to be pushed to 10.2) will prevent xtrabackup from working at all. It changes the InnoDB redo log format tag, which will prevent older 10.2 versions from doing crash-downgrade (or versions before MDEV-14909 , even a downgrade after clean shutdown).
            marko Marko Mäkelä added a comment -

            Now that MariaDB Server 10.2.19 will include the fix of MDEV-13564, xtrabackup will no longer work, and I believe that we must remove all references to it starting from 10.2.19.

            marko Marko Mäkelä added a comment - Now that MariaDB Server 10.2.19 will include the fix of MDEV-13564 , xtrabackup will no longer work, and I believe that we must remove all references to it starting from 10.2.19.
            winstone Zdravelina Sokolovska (Inactive) added a comment -

            Changing the galera_ist_xtrabackup-v2.test is duplicating the alredy existing galera_sst_mariabackup.test

            winstone Zdravelina Sokolovska (Inactive) added a comment - Changing the galera_ist_xtrabackup-v2.test is duplicating the alredy existing galera_sst_mariabackup.test
            winstone Zdravelina Sokolovska (Inactive) added a comment - - edited

            added test cases
            galera_autoinc_sst_mariabackup
            galera_ist_mariabackup_innodb_flush_logs
            galera_sst_mariabackup-options
            galera_sst_mariabackup_encrypt_with_key
            https://github.com/MariaDB/server/pull/872

            winstone Zdravelina Sokolovska (Inactive) added a comment - - edited added test cases galera_autoinc_sst_mariabackup galera_ist_mariabackup_innodb_flush_logs galera_sst_mariabackup-options galera_sst_mariabackup_encrypt_with_key https://github.com/MariaDB/server/pull/872
            winstone Zdravelina Sokolovska (Inactive) added a comment - - edited

            updated the galera disabled.def with galera_autoinc_sst_xtrabackup, galera_ist_innodb_flush_logs, galera_ist_xtrabackup-v2, galera_sst_xtrabackup-v2-options, galera_sst_xtrabackup-v2_encrypt_with_key tests due to MDEV-17304 Replace use of XtraBackup with MariaDB Backup
            https://github.com/MariaDB/server/pull/872

            winstone Zdravelina Sokolovska (Inactive) added a comment - - edited updated the galera disabled.def with galera_autoinc_sst_xtrabackup, galera_ist_innodb_flush_logs, galera_ist_xtrabackup-v2, galera_sst_xtrabackup-v2-options, galera_sst_xtrabackup-v2_encrypt_with_key tests due to MDEV-17304 Replace use of XtraBackup with MariaDB Backup https://github.com/MariaDB/server/pull/872
            jplindst Jan Lindström (Inactive) added a comment -
            • 10.2: Added mariabackup tests, xtrabackup tests with innodb-safe-truncate=off
            • 10.3: Disabled xtrabackup tests as they can't work
            jplindst Jan Lindström (Inactive) added a comment - 10.2: Added mariabackup tests, xtrabackup tests with innodb-safe-truncate=off 10.3: Disabled xtrabackup tests as they can't work

            People

              jplindst Jan Lindström (Inactive)
              seppo Seppo Jaakola
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.