[MDEV-15522] Change galera suite MTR tests to use mariabackup instead of xtrabackup Created: 2018-03-09  Updated: 2018-11-30  Resolved: 2018-11-28

Status: Closed
Project: MariaDB Server
Component/s: Galera SST, Tests
Fix Version/s: 10.4.1, 10.2.20, 10.3.12

Type: Task Priority: Critical
Reporter: Seppo Jaakola Assignee: Jan Lindström (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Blocks
blocks MDEV-13549 Galera 3 test failures Closed
is blocked by MDEV-17771 Add Galera ist and sst tests using ma... Closed
Relates
relates to MDEV-11369 Instant add column for InnoDB Closed
relates to MDEV-12288 Reset DB_TRX_ID when the history is r... Closed
relates to MDEV-12289 Keep 128 persistent rollback segments... Closed
relates to MDEV-12548 Add maria backup tool to MariaDB 10.2 Closed
relates to MDEV-13564 TRUNCATE TABLE and undo tablespace tr... Closed
relates to MDEV-17304 Replace use of XtraBackup with MariaD... Closed
relates to MDEV-17835 Remove wsrep-sst-method=xtrabackup Closed

 Description   

Galera MTR suite has following tests, which are configured to use xtrabackup as SST method:
galera_autoinc_sst_xtrabackup
galera_ist_innodb_flush_logs
galera_ist_xtrabackup-v2
galera_sst_xtrabackup-v2-options
galera_sst_xtrabackup-v2_encrypt_with_key

And there are no tests using mariabackup, at the moment.

Starting from MariaDB 10.2, xtrabackup (version 2.4) does not work with the reviced redo log format. Therefore it is substantial to either add mariabackup as option for SST or to change all SST tests to use mariabackup instead of xtrabackup.

 Comments   
Comment by Sergey Vojtovich [ 2018-03-12 ]

jplindst, please review https://github.com/MariaDB/server/pull/648

Comment by Marko Mäkelä [ 2018-09-06 ]

Percona Xtrabackup may be unsafe to use with MariaDB 10.2, because it may process undo log records in a way that is incompatible with the changes implemented in MDEV-12289 (to maintain undo log compatibility with older versions of MariaDB and MySQL up to 5.6).

Xtrabackup cannot possibly work with the new redo log format introduced in MariaDB 10.3 for MDEV-12288 and MDEV-11369. It also never worked with innodb_encrypt_log. While we are at this, maybe the transfer of encrypted InnoDB data and log files should be covered by tests?

Comment by Jan Lindström (Inactive) [ 2018-09-06 ]

winstone Could you start by applying the pull request and then try to fix the actual test cases one by one to get this issue fixed ?

Comment by Marko Mäkelä [ 2018-09-06 ]

As far as I can tell, the pull request does not replace references to xtrabackup or innobackupex in scripts/wsrep_sst_xtrabackup*. In fact, it does not touch those scripts at all. I do not think that those scripts have any reason to exist in MariaDB 10.2+.

Comment by Zdravelina Sokolovska (Inactive) [ 2018-09-10 ]

in my opinion it is more appropriate to update galera test suite MTR with separate mariabackup tests , instead of change the available MTR xtrabackup,xtrabackup-v2 tests — refer to MDEV-16018, as well MDEV-16019

Comment by Marko Mäkelä [ 2018-09-13 ]

I think that we have no other choice than to remove the xtrabackup scripts from 10.2, because the crash-downgrade prevention in MDEV-13564 (which is planned to be pushed to 10.2) will prevent xtrabackup from working at all. It changes the InnoDB redo log format tag, which will prevent older 10.2 versions from doing crash-downgrade (or versions before MDEV-14909, even a downgrade after clean shutdown).

Comment by Marko Mäkelä [ 2018-09-26 ]

Now that MariaDB Server 10.2.19 will include the fix of MDEV-13564, xtrabackup will no longer work, and I believe that we must remove all references to it starting from 10.2.19.

Comment by Zdravelina Sokolovska (Inactive) [ 2018-10-01 ]

Changing the galera_ist_xtrabackup-v2.test is duplicating the alredy existing galera_sst_mariabackup.test

Comment by Zdravelina Sokolovska (Inactive) [ 2018-10-01 ]

added test cases
galera_autoinc_sst_mariabackup
galera_ist_mariabackup_innodb_flush_logs
galera_sst_mariabackup-options
galera_sst_mariabackup_encrypt_with_key
https://github.com/MariaDB/server/pull/872

Comment by Zdravelina Sokolovska (Inactive) [ 2018-10-01 ]

updated the galera disabled.def with galera_autoinc_sst_xtrabackup, galera_ist_innodb_flush_logs, galera_ist_xtrabackup-v2, galera_sst_xtrabackup-v2-options, galera_sst_xtrabackup-v2_encrypt_with_key tests due to MDEV-17304 Replace use of XtraBackup with MariaDB Backup
https://github.com/MariaDB/server/pull/872

Comment by Jan Lindström (Inactive) [ 2018-11-28 ]
  • 10.2: Added mariabackup tests, xtrabackup tests with innodb-safe-truncate=off
  • 10.3: Disabled xtrabackup tests as they can't work
Generated at Thu Feb 08 08:21:57 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.