[MDEV-15522] Change galera suite MTR tests to use mariabackup instead of xtrabackup - Jira

Details

Type: Task
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Fix Version/s: 10.4.1, 10.2.20, 10.3.12
Component/s: Galera SST, Tests
Labels:
None

Description

Galera MTR suite has following tests, which are configured to use xtrabackup as SST method:
galera_autoinc_sst_xtrabackup
galera_ist_innodb_flush_logs
galera_ist_xtrabackup-v2
galera_sst_xtrabackup-v2-options
galera_sst_xtrabackup-v2_encrypt_with_key

And there are no tests using mariabackup, at the moment.

Starting from MariaDB 10.2, xtrabackup (version 2.4) does not work with the reviced redo log format. Therefore it is substantial to either add mariabackup as option for SST or to change all SST tests to use mariabackup instead of xtrabackup.

Attachments

Issue Links

blocks

MDEV-13549 Galera 3 test failures

Closed

is blocked by

MDEV-17771 Add Galera ist and sst tests using mariabackup

Closed

relates to

MDEV-11369 Instant add column for InnoDB

Closed

MDEV-12288 Reset DB_TRX_ID when the history is removed, to speed up MVCC

Closed

MDEV-12289 Keep 128 persistent rollback segments for compatibility and performance

Closed

MDEV-12548 Add maria backup tool to MariaDB 10.2

Closed

MDEV-13564 TRUNCATE TABLE and undo tablespace truncation are not compatible with Mariabackup

Closed

MDEV-17304 Replace use of XtraBackup with MariaDB Backup

Closed

MDEV-17835 Remove wsrep-sst-method=xtrabackup

Closed

(4 relates to)

Activity

Ascending order - Click to sort in descending order

Seppo Jaakola created issue - 2018-03-09 09:06

Seppo Jaakola made changes - 2018-03-09 09:13

Field	Original Value	New Value
Fix Version/s		10.2 [ 14601 ]
Fix Version/s		10.3 [ 22126 ]

Sergey Vojtovich made changes - 2018-03-12 12:06

Status

Open [ 1 ]

Confirmed [ 10101 ]

Sergey Vojtovich made changes - 2018-03-12 12:06

Labels

contribution foundation

Sergey Vojtovich made changes - 2018-03-12 12:06

Assignee

Seppo Jaakola [ seppo ]

Jan Lindström [ jplindst ]

Sergey Vojtovich added a comment - 2018-03-12 12:06

jplindst, please review https://github.com/MariaDB/server/pull/648

Sergey Vojtovich added a comment - 2018-03-12 12:06 jplindst , please review https://github.com/MariaDB/server/pull/648

Sergei Golubchik made changes - 2018-07-09 12:56

Labels

contribution foundation

Marko Mäkelä made changes - 2018-09-06 06:24

Link

This issue relates to ~~MDEV-11369~~ [ ~~MDEV-11369~~ ]

Marko Mäkelä made changes - 2018-09-06 06:24

Link

This issue relates to ~~MDEV-12548~~ [ ~~MDEV-12548~~ ]

Marko Mäkelä added a comment - 2018-09-06 06:24

Percona Xtrabackup may be unsafe to use with MariaDB 10.2, because it may process undo log records in a way that is incompatible with the changes implemented in ~~MDEV-12289~~ (to maintain undo log compatibility with older versions of MariaDB and MySQL up to 5.6).

Xtrabackup cannot possibly work with the new redo log format introduced in MariaDB 10.3 for ~~MDEV-12288~~ and ~~MDEV-11369~~. It also never worked with innodb_encrypt_log. While we are at this, maybe the transfer of encrypted InnoDB data and log files should be covered by tests?

Marko Mäkelä added a comment - 2018-09-06 06:24 Percona Xtrabackup may be unsafe to use with MariaDB 10.2, because it may process undo log records in a way that is incompatible with the changes implemented in MDEV-12289 (to maintain undo log compatibility with older versions of MariaDB and MySQL up to 5.6). Xtrabackup cannot possibly work with the new redo log format introduced in MariaDB 10.3 for MDEV-12288 and MDEV-11369 . It also never worked with innodb_encrypt_log . While we are at this, maybe the transfer of encrypted InnoDB data and log files should be covered by tests?

Marko Mäkelä made changes - 2018-09-06 06:24

Link

This issue relates to ~~MDEV-12289~~ [ ~~MDEV-12289~~ ]

Marko Mäkelä made changes - 2018-09-06 06:24

Link

This issue relates to ~~MDEV-12288~~ [ ~~MDEV-12288~~ ]

Jan Lindström (Inactive) made changes - 2018-09-06 06:26

Assignee

Jan Lindström [ jplindst ]

winstone [ winstone ]

Jan Lindström (Inactive) added a comment - 2018-09-06 06:28

winstone Could you start by applying the pull request and then try to fix the actual test cases one by one to get this issue fixed ?

Jan Lindström (Inactive) added a comment - 2018-09-06 06:28 winstone Could you start by applying the pull request and then try to fix the actual test cases one by one to get this issue fixed ?

Jan Lindström (Inactive) made changes - 2018-09-06 06:28

Priority

Major [ 3 ]

Critical [ 2 ]

Marko Mäkelä added a comment - 2018-09-06 06:31

As far as I can tell, the pull request does not replace references to xtrabackup or innobackupex in scripts/wsrep_sst_xtrabackup*. In fact, it does not touch those scripts at all. I do not think that those scripts have any reason to exist in MariaDB 10.2+.

Marko Mäkelä added a comment - 2018-09-06 06:31 As far as I can tell, the pull request does not replace references to xtrabackup or innobackupex in scripts/wsrep_sst_xtrabackup* . In fact, it does not touch those scripts at all. I do not think that those scripts have any reason to exist in MariaDB 10.2+.

Jan Lindström (Inactive) made changes - 2018-09-06 08:02

Link

This issue blocks ~~MDEV-13549~~ [ ~~MDEV-13549~~ ]

Zdravelina Sokolovska (Inactive) added a comment - 2018-09-10 10:05 - edited

in my opinion it is more appropriate to update galera test suite MTR with separate mariabackup tests , instead of change the available MTR xtrabackup,xtrabackup-v2 tests — refer to ~~MDEV-16018~~, as well ~~MDEV-16019~~

Zdravelina Sokolovska (Inactive) added a comment - 2018-09-10 10:05 - edited in my opinion it is more appropriate to update galera test suite MTR with separate mariabackup tests , instead of change the available MTR xtrabackup,xtrabackup-v2 tests — refer to MDEV-16018 , as well MDEV-16019

Marko Mäkelä added a comment - 2018-09-13 14:29

I think that we have no other choice than to remove the xtrabackup scripts from 10.2, because the crash-downgrade prevention in ~~MDEV-13564~~ (which is planned to be pushed to 10.2) will prevent xtrabackup from working at all. It changes the InnoDB redo log format tag, which will prevent older 10.2 versions from doing crash-downgrade (or versions before ~~MDEV-14909~~, even a downgrade after clean shutdown).

Marko Mäkelä added a comment - 2018-09-13 14:29 I think that we have no other choice than to remove the xtrabackup scripts from 10.2, because the crash-downgrade prevention in MDEV-13564 (which is planned to be pushed to 10.2) will prevent xtrabackup from working at all. It changes the InnoDB redo log format tag, which will prevent older 10.2 versions from doing crash-downgrade (or versions before MDEV-14909 , even a downgrade after clean shutdown).

Marko Mäkelä made changes - 2018-09-13 14:29

Link

This issue relates to ~~MDEV-13564~~ [ ~~MDEV-13564~~ ]

Marko Mäkelä made changes - 2018-09-26 11:14

Fix Version/s		10.2.19 [ 23207 ]
Fix Version/s	10.2 [ 14601 ]

Marko Mäkelä made changes - 2018-09-26 11:14

Priority

Critical [ 2 ]

Blocker [ 1 ]

Marko Mäkelä added a comment - 2018-09-26 11:16

Now that MariaDB Server 10.2.19 will include the fix of ~~MDEV-13564~~, xtrabackup will no longer work, and I believe that we must remove all references to it starting from 10.2.19.

Marko Mäkelä added a comment - 2018-09-26 11:16 Now that MariaDB Server 10.2.19 will include the fix of MDEV-13564 , xtrabackup will no longer work, and I believe that we must remove all references to it starting from 10.2.19.

Rasmus Johansson (Inactive) made changes - 2018-09-27 11:21

Link

This issue relates to ~~MDEV-17304~~ [ ~~MDEV-17304~~ ]

Zdravelina Sokolovska (Inactive) made changes - 2018-09-27 14:03

Fix Version/s

10.4 [ 22408 ]

Sergei Golubchik made changes - 2018-10-01 08:21

Fix Version/s		10.2 [ 14601 ]
Fix Version/s	10.2.19 [ 23207 ]

Sergei Golubchik made changes - 2018-10-01 08:21

Priority

Blocker [ 1 ]

Critical [ 2 ]

Zdravelina Sokolovska (Inactive) made changes - 2018-10-01 14:34

Status

Confirmed [ 10101 ]

In Progress [ 3 ]

Zdravelina Sokolovska (Inactive) made changes - 2018-10-01 14:34

Status

In Progress [ 3 ]

Stalled [ 10000 ]

Zdravelina Sokolovska (Inactive) made changes - 2018-10-01 14:34

Status

Stalled [ 10000 ]

Open [ 1 ]

Zdravelina Sokolovska (Inactive) added a comment - 2018-10-01 14:36

Changing the galera_ist_xtrabackup-v2.test is duplicating the alredy existing galera_sst_mariabackup.test

Zdravelina Sokolovska (Inactive) added a comment - 2018-10-01 14:36 Changing the galera_ist_xtrabackup-v2.test is duplicating the alredy existing galera_sst_mariabackup.test

Zdravelina Sokolovska (Inactive) added a comment - 2018-10-01 14:38 - edited

added test cases
galera_autoinc_sst_mariabackup
galera_ist_mariabackup_innodb_flush_logs
galera_sst_mariabackup-options
galera_sst_mariabackup_encrypt_with_key
https://github.com/MariaDB/server/pull/872

Zdravelina Sokolovska (Inactive) added a comment - 2018-10-01 14:38 - edited added test cases galera_autoinc_sst_mariabackup galera_ist_mariabackup_innodb_flush_logs galera_sst_mariabackup-options galera_sst_mariabackup_encrypt_with_key https://github.com/MariaDB/server/pull/872

Zdravelina Sokolovska (Inactive) added a comment - 2018-10-01 15:52 - edited

updated the galera disabled.def with galera_autoinc_sst_xtrabackup, galera_ist_innodb_flush_logs, galera_ist_xtrabackup-v2, galera_sst_xtrabackup-v2-options, galera_sst_xtrabackup-v2_encrypt_with_key tests due to ~~MDEV-17304~~ Replace use of XtraBackup with MariaDB Backup
https://github.com/MariaDB/server/pull/872

Zdravelina Sokolovska (Inactive) added a comment - 2018-10-01 15:52 - edited updated the galera disabled.def with galera_autoinc_sst_xtrabackup, galera_ist_innodb_flush_logs, galera_ist_xtrabackup-v2, galera_sst_xtrabackup-v2-options, galera_sst_xtrabackup-v2_encrypt_with_key tests due to MDEV-17304 Replace use of XtraBackup with MariaDB Backup https://github.com/MariaDB/server/pull/872

Zdravelina Sokolovska (Inactive) made changes - 2018-10-01 16:10

Assignee

Zdravelina Sokolovska [ winstone ]

Jan Lindström (Inactive) made changes - 2018-11-19 15:25

Assignee

Jan Lindström [ jplindst ]

Jan Lindström (Inactive) made changes - 2018-11-19 15:25

Status

Open [ 1 ]

In Progress [ 3 ]

Marko Mäkelä made changes - 2018-11-19 15:38

Link

This issue is blocked by ~~MDEV-17771~~ [ ~~MDEV-17771~~ ]

Marko Mäkelä made changes - 2018-11-26 13:06

Link

This issue relates to ~~MDEV-17835~~ [ ~~MDEV-17835~~ ]

Jan Lindström (Inactive) added a comment - 2018-11-28 08:05

10.2: Added mariabackup tests, xtrabackup tests with innodb-safe-truncate=off
10.3: Disabled xtrabackup tests as they can't work

Jan Lindström (Inactive) added a comment - 2018-11-28 08:05 10.2: Added mariabackup tests, xtrabackup tests with innodb-safe-truncate=off 10.3: Disabled xtrabackup tests as they can't work

Jan Lindström (Inactive) made changes - 2018-11-28 08:05

issue.field.resolutiondate

2018-11-28 08:05:15.0

2018-11-28 08:05:15.082

Jan Lindström (Inactive) made changes - 2018-11-28 08:05

Fix Version/s		10.4.1 [ 23228 ]
Fix Version/s		10.2.20 [ 23212 ]
Fix Version/s		10.3.12 [ 23214 ]
Fix Version/s	10.2 [ 14601 ]
Fix Version/s	10.3 [ 22126 ]
Fix Version/s	10.4 [ 22408 ]
Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Closed [ 6 ]

Sergei Golubchik made changes - 2021-12-06 21:23

Workflow

MariaDB v3 [ 85935 ]

MariaDB v4 [ 133489 ]

People

Assignee:: Jan Lindström (Inactive)

Reporter:: Seppo Jaakola

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 2018-03-09 09:06

Updated:: 2018-11-30 07:38

Resolved:: 2018-11-28 08:05

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.