Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15477

SESSION_SYSVARS_TRACKER does not track last_gtid

Details

    • Bug
    • Status: Closed (View Workflow)
    • Critical
    • Resolution: Fixed
    • 10.2(EOL), 10.3(EOL)
    • 10.2.16, 10.3.8
    • Server
    • None
    • 10.2.14, 10.3.6-1

    Description

      SESSION_SYSVARS_TRACKER does not track last_gtid

      Attachments

        Issue Links

          Activity

            csets:
            revision-id: f2b91c878cf4ec53c292caba7f5907d1ef724de4 (mariadb-10.2.13-30-gf2b91c878cf)
            parent(s): 8f98835bb86550a68a6c412d8417cc169dfdc206
            author: Oleksandr Byelkin
            committer: Oleksandr Byelkin
            timestamp: 2018-03-09 14:26:10 +0100
            message:

            Reset connection support in mysqltest

            revision-id: 6cf25e5eb76923550173a0059036d80c80a053d6 (mariadb-10.2.13-31-g6cf25e5eb76)
            parent(s): f2b91c878cf4ec53c292caba7f5907d1ef724de4
            author: Oleksandr Byelkin
            committer: Oleksandr Byelkin
            timestamp: 2018-03-09 14:27:13 +0100
            message:

            Session tracking info support in mysqltest

            revision-id: dc3d6c9edb3536e5f0c87ac1e9c04891d50fc420 (mariadb-10.2.13-32-gdc3d6c9edb3)
            parent(s): 6cf25e5eb76923550173a0059036d80c80a053d6
            author: Oleksandr Byelkin
            committer: Oleksandr Byelkin
            timestamp: 2018-03-09 14:39:40 +0100
            message:

            MDEV-15477: SESSION_SYSVARS_TRACKER does not track last_gtid

            register changes of last_gtid

            sanja Oleksandr Byelkin added a comment - csets: revision-id: f2b91c878cf4ec53c292caba7f5907d1ef724de4 (mariadb-10.2.13-30-gf2b91c878cf) parent(s): 8f98835bb86550a68a6c412d8417cc169dfdc206 author: Oleksandr Byelkin committer: Oleksandr Byelkin timestamp: 2018-03-09 14:26:10 +0100 message: Reset connection support in mysqltest revision-id: 6cf25e5eb76923550173a0059036d80c80a053d6 (mariadb-10.2.13-31-g6cf25e5eb76) parent(s): f2b91c878cf4ec53c292caba7f5907d1ef724de4 author: Oleksandr Byelkin committer: Oleksandr Byelkin timestamp: 2018-03-09 14:27:13 +0100 message: Session tracking info support in mysqltest — revision-id: dc3d6c9edb3536e5f0c87ac1e9c04891d50fc420 (mariadb-10.2.13-32-gdc3d6c9edb3) parent(s): 6cf25e5eb76923550173a0059036d80c80a053d6 author: Oleksandr Byelkin committer: Oleksandr Byelkin timestamp: 2018-03-09 14:39:40 +0100 message: MDEV-15477 : SESSION_SYSVARS_TRACKER does not track last_gtid register changes of last_gtid —

            All commits are on bb-10.2-MDEV-15477 branch on github. First 2 is just port from mysql.

            There is no test suite for sessions absent because we have problem with SET @@session.session_track_state_change=ON; which crash client so plan to submit the bug against client library as soon as this will be pushed.

            sanja Oleksandr Byelkin added a comment - All commits are on bb-10.2- MDEV-15477 branch on github. First 2 is just port from mysql. There is no test suite for sessions absent because we have problem with SET @@session.session_track_state_change=ON; which crash client so plan to submit the bug against client library as soon as this will be pushed.

            commit 7a7ca6556ffafc40d51c06bafe52e278a8081085 (HEAD > bb-10.2MDEV-15477, origin/bb-10.2-MDEV-15477)
            Author: Oleksandr Byelkin <sanja@mariadb.com>
            Date: Mon Mar 12 14:46:00 2018 +0100

            Optimize charset tracking a bit.

            commit 568ce91b90653e34c637d56942fe7aed8ab97bd2
            Author: Oleksandr Byelkin <sanja@mariadb.com>
            Date: Fri Mar 9 14:39:40 2018 +0100

            MDEV-15477: SESSION_SYSVARS_TRACKER does not track last_gtid

            register changes of last_gtid

            commit 2242e537fc2ea7e24ad6733b449280d6a8115007
            Author: Oleksandr Byelkin <sanja@mariadb.com>
            Date: Fri Mar 9 14:27:13 2018 +0100

            Session tracking info support in mysqltest (port from mysql)

            commit 249c35d37e144f2cea9ab877e34351eec4c81485
            Author: Oleksandr Byelkin <sanja@mariadb.com>
            Date: Fri Mar 9 14:26:10 2018 +0100

            Reset connection support in mysqltest (port from mysql)

            sanja Oleksandr Byelkin added a comment - commit 7a7ca6556ffafc40d51c06bafe52e278a8081085 (HEAD > bb-10.2 MDEV-15477 , origin/bb-10.2- MDEV-15477 ) Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Mon Mar 12 14:46:00 2018 +0100 Optimize charset tracking a bit. commit 568ce91b90653e34c637d56942fe7aed8ab97bd2 Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Fri Mar 9 14:39:40 2018 +0100 MDEV-15477 : SESSION_SYSVARS_TRACKER does not track last_gtid register changes of last_gtid commit 2242e537fc2ea7e24ad6733b449280d6a8115007 Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Fri Mar 9 14:27:13 2018 +0100 Session tracking info support in mysqltest (port from mysql) commit 249c35d37e144f2cea9ab877e34351eec4c81485 Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Fri Mar 9 14:26:10 2018 +0100 Reset connection support in mysqltest (port from mysql)
            serg Sergei Golubchik added a comment - - edited
            1. Do you need to lock LOCK_plugin when updating the tracker?
            2. What about my suggestion of using a getter and a setter?
            serg Sergei Golubchik added a comment - - edited Do you need to lock LOCK_plugin when updating the tracker? What about my suggestion of using a getter and a setter?

            1. I see it as protection against removing plugin with its variables when we already take pointer on it but not jet reported value in OK.
            2. I thought it is not obligatory (I preferred to keep patch small), but if you want I can do it, no problem.

            sanja Oleksandr Byelkin added a comment - 1. I see it as protection against removing plugin with its variables when we already take pointer on it but not jet reported value in OK. 2. I thought it is not obligatory (I preferred to keep patch small), but if you want I can do it, no problem.

            commit 07ed346ebdad6c661682d46ec21f2f09d439573d (HEAD > bb-10.2MDEV-15477, origin/bb-10.2-MDEV-15477)
            Author: Oleksandr Byelkin <sanja@mariadb.com>
            Date: Mon Mar 12 14:46:00 2018 +0100

            Optimize charset tracking a bit.

            commit 943e0b77d567141963b17d1c83b4e5692c46ebc4
            Author: Oleksandr Byelkin <sanja@mariadb.com>
            Date: Fri Mar 9 14:39:40 2018 +0100

            MDEV-15477: SESSION_SYSVARS_TRACKER does not track last_gtid

            register changes of last_gtid

            commit a7068c05c3d6c4b268f63ae6add9a7d8168fdb8b
            Author: Oleksandr Byelkin <sanja@mariadb.com>
            Date: Fri Mar 9 14:27:13 2018 +0100

            Session tracking info support in mysqltest (port from mysql)

            sanja Oleksandr Byelkin added a comment - commit 07ed346ebdad6c661682d46ec21f2f09d439573d (HEAD > bb-10.2 MDEV-15477 , origin/bb-10.2- MDEV-15477 ) Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Mon Mar 12 14:46:00 2018 +0100 Optimize charset tracking a bit. commit 943e0b77d567141963b17d1c83b4e5692c46ebc4 Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Fri Mar 9 14:39:40 2018 +0100 MDEV-15477 : SESSION_SYSVARS_TRACKER does not track last_gtid register changes of last_gtid commit a7068c05c3d6c4b268f63ae6add9a7d8168fdb8b Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Fri Mar 9 14:27:13 2018 +0100 Session tracking info support in mysqltest (port from mysql)

            ok to push!

            serg Sergei Golubchik added a comment - ok to push!

            People

              sanja Oleksandr Byelkin
              serg Sergei Golubchik
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.