[MDEV-15477] SESSION_SYSVARS_TRACKER does not track last_gtid Created: 2018-03-06  Updated: 2018-06-26  Resolved: 2018-06-26

Status: Closed
Project: MariaDB Server
Component/s: Server
Affects Version/s: 10.2, 10.3
Fix Version/s: 10.2.16, 10.3.8

Type: Bug Priority: Critical
Reporter: Sergei Golubchik Assignee: Oleksandr Byelkin
Resolution: Fixed Votes: 1
Labels: None

Issue Links:
Blocks
blocks MXS-1778 Consistent reads by the utlization of... Closed
Duplicate
is duplicated by MDEV-11956 Get last_gtid in OK packet. Closed
Relates
relates to MDEV-11956 Get last_gtid in OK packet. Closed
Sprint: 10.2.14, 10.3.6-1

 Description   

SESSION_SYSVARS_TRACKER does not track last_gtid



 Comments   
Comment by Oleksandr Byelkin [ 2018-03-09 ]

csets:
revision-id: f2b91c878cf4ec53c292caba7f5907d1ef724de4 (mariadb-10.2.13-30-gf2b91c878cf)
parent(s): 8f98835bb86550a68a6c412d8417cc169dfdc206
author: Oleksandr Byelkin
committer: Oleksandr Byelkin
timestamp: 2018-03-09 14:26:10 +0100
message:

Reset connection support in mysqltest

revision-id: 6cf25e5eb76923550173a0059036d80c80a053d6 (mariadb-10.2.13-31-g6cf25e5eb76)
parent(s): f2b91c878cf4ec53c292caba7f5907d1ef724de4
author: Oleksandr Byelkin
committer: Oleksandr Byelkin
timestamp: 2018-03-09 14:27:13 +0100
message:

Session tracking info support in mysqltest

revision-id: dc3d6c9edb3536e5f0c87ac1e9c04891d50fc420 (mariadb-10.2.13-32-gdc3d6c9edb3)
parent(s): 6cf25e5eb76923550173a0059036d80c80a053d6
author: Oleksandr Byelkin
committer: Oleksandr Byelkin
timestamp: 2018-03-09 14:39:40 +0100
message:

MDEV-15477: SESSION_SYSVARS_TRACKER does not track last_gtid

register changes of last_gtid

Comment by Oleksandr Byelkin [ 2018-03-09 ]

All commits are on bb-10.2-MDEV-15477 branch on github. First 2 is just port from mysql.

There is no test suite for sessions absent because we have problem with SET @@session.session_track_state_change=ON; which crash client so plan to submit the bug against client library as soon as this will be pushed.

Comment by Oleksandr Byelkin [ 2018-03-12 ]

commit 7a7ca6556ffafc40d51c06bafe52e278a8081085 (HEAD > bb-10.2MDEV-15477, origin/bb-10.2-MDEV-15477)
Author: Oleksandr Byelkin <sanja@mariadb.com>
Date: Mon Mar 12 14:46:00 2018 +0100

Optimize charset tracking a bit.

commit 568ce91b90653e34c637d56942fe7aed8ab97bd2
Author: Oleksandr Byelkin <sanja@mariadb.com>
Date: Fri Mar 9 14:39:40 2018 +0100

MDEV-15477: SESSION_SYSVARS_TRACKER does not track last_gtid

register changes of last_gtid

commit 2242e537fc2ea7e24ad6733b449280d6a8115007
Author: Oleksandr Byelkin <sanja@mariadb.com>
Date: Fri Mar 9 14:27:13 2018 +0100

Session tracking info support in mysqltest (port from mysql)

commit 249c35d37e144f2cea9ab877e34351eec4c81485
Author: Oleksandr Byelkin <sanja@mariadb.com>
Date: Fri Mar 9 14:26:10 2018 +0100

Reset connection support in mysqltest (port from mysql)

Comment by Sergei Golubchik [ 2018-06-18 ]
  1. Do you need to lock LOCK_plugin when updating the tracker?
  2. What about my suggestion of using a getter and a setter?
Comment by Oleksandr Byelkin [ 2018-06-19 ]

1. I see it as protection against removing plugin with its variables when we already take pointer on it but not jet reported value in OK.
2. I thought it is not obligatory (I preferred to keep patch small), but if you want I can do it, no problem.

Comment by Oleksandr Byelkin [ 2018-06-19 ]

commit 07ed346ebdad6c661682d46ec21f2f09d439573d (HEAD > bb-10.2MDEV-15477, origin/bb-10.2-MDEV-15477)
Author: Oleksandr Byelkin <sanja@mariadb.com>
Date: Mon Mar 12 14:46:00 2018 +0100

Optimize charset tracking a bit.

commit 943e0b77d567141963b17d1c83b4e5692c46ebc4
Author: Oleksandr Byelkin <sanja@mariadb.com>
Date: Fri Mar 9 14:39:40 2018 +0100

MDEV-15477: SESSION_SYSVARS_TRACKER does not track last_gtid

register changes of last_gtid

commit a7068c05c3d6c4b268f63ae6add9a7d8168fdb8b
Author: Oleksandr Byelkin <sanja@mariadb.com>
Date: Fri Mar 9 14:27:13 2018 +0100

Session tracking info support in mysqltest (port from mysql)

Comment by Sergei Golubchik [ 2018-06-20 ]

ok to push!

Generated at Thu Feb 08 08:21:37 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.