MDEV-7108 changed the type of the variable srv_fatal_semaphore_wait_threshold from ulint to ulong but failed to adjust the assignments accordingly.
In MariaDB 10.2, some wrong code reads like this:
my_atomic_addlint(
|
&srv_fatal_semaphore_wait_threshold,
|
SRV_SEMAPHORE_WAIT_EXTENSION);
|
In MariaDB 10.1, it reads like this:
os_increment_counter_by_amount(
|
server_mutex,
|
srv_fatal_semaphore_wait_threshold,
|
SRV_SEMAPHORE_WAIT_EXTENSION);
|
Both of these forms expect the data type to be ulint.
As far as I understand, on most platforms sizeof(ulong)==sizeof(ulint) would hold. Most notably, the sizes are different on 64-bit WIndows (4 and 8 bytes).
The problem was found by wlad by compiling 10.3 cmake -DWITH_ASAN and running tests on Windows.
- is caused by
-
MDEV-7108
Made long semaphore wait timeout configurable
-
-
Closed
{"report":{"fcp":1225.0999994277954,"ttfb":496.19999980926514,"pageVisibility":"visible","entityId":65853,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"de6b2ac5-6a47-4cfa-8ed6-c4caaffbec56","navigationType":0,"readyForUser":1335.6999998092651,"redirectCount":0,"resourceLoadedEnd":1396.8999996185303,"resourceLoadedStart":501.0999994277954,"resourceTiming":[{"duration":238.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":501.0999994277954,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":501.0999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":739.8999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":238.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":501.3999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":501.3999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":740.1999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":247.60000038146973,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":501.5999994277954,"connectEnd":501.5999994277954,"connectStart":501.5999994277954,"domainLookupEnd":501.5999994277954,"domainLookupStart":501.5999994277954,"fetchStart":501.5999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":501.5999994277954,"responseEnd":749.1999998092651,"responseStart":749.1999998092651,"secureConnectionStart":501.5999994277954},{"duration":282.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":501.69999980926514,"connectEnd":501.69999980926514,"connectStart":501.69999980926514,"domainLookupEnd":501.69999980926514,"domainLookupStart":501.69999980926514,"fetchStart":501.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":501.69999980926514,"responseEnd":783.8999996185303,"responseStart":783.8999996185303,"secureConnectionStart":501.69999980926514},{"duration":286,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":502,"connectEnd":502,"connectStart":502,"domainLookupEnd":502,"domainLookupStart":502,"fetchStart":502,"redirectEnd":0,"redirectStart":0,"requestStart":502,"responseEnd":788,"responseStart":788,"secureConnectionStart":502},{"duration":286.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":502.19999980926514,"connectEnd":502.19999980926514,"connectStart":502.19999980926514,"domainLookupEnd":502.19999980926514,"domainLookupStart":502.19999980926514,"fetchStart":502.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":502.19999980926514,"responseEnd":788.6999998092651,"responseStart":788.6999998092651,"secureConnectionStart":502.19999980926514},{"duration":287.1000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":502.19999980926514,"connectEnd":502.19999980926514,"connectStart":502.19999980926514,"domainLookupEnd":502.19999980926514,"domainLookupStart":502.19999980926514,"fetchStart":502.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":502.19999980926514,"responseEnd":789.3000001907349,"responseStart":789.3000001907349,"secureConnectionStart":502.19999980926514},{"duration":392.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":502.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":502.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":894.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":288.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":502.5999994277954,"connectEnd":502.5999994277954,"connectStart":502.5999994277954,"domainLookupEnd":502.5999994277954,"domainLookupStart":502.5999994277954,"fetchStart":502.5999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":502.5999994277954,"responseEnd":790.8999996185303,"responseStart":790.8999996185303,"secureConnectionStart":502.5999994277954},{"duration":392,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":502.8999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":502.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":894.8999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":289.8999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":503,"connectEnd":503,"connectStart":503,"domainLookupEnd":503,"domainLookupStart":503,"fetchStart":503,"redirectEnd":0,"redirectStart":0,"requestStart":503,"responseEnd":792.8999996185303,"responseStart":792.8999996185303,"secureConnectionStart":503},{"duration":541.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":508.5,"connectEnd":508.5,"connectStart":508.5,"domainLookupEnd":508.5,"domainLookupStart":508.5,"fetchStart":508.5,"redirectEnd":0,"redirectStart":0,"requestStart":508.5,"responseEnd":1050,"responseStart":1050,"secureConnectionStart":508.5},{"duration":720.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":508.69999980926514,"connectEnd":508.69999980926514,"connectStart":508.69999980926514,"domainLookupEnd":508.69999980926514,"domainLookupStart":508.69999980926514,"fetchStart":508.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":508.69999980926514,"responseEnd":1228.8999996185303,"responseStart":1228.8999996185303,"secureConnectionStart":508.69999980926514},{"duration":144.69999980926514,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":906.5,"connectEnd":906.5,"connectStart":906.5,"domainLookupEnd":906.5,"domainLookupStart":906.5,"fetchStart":906.5,"redirectEnd":0,"redirectStart":0,"requestStart":906.5,"responseEnd":1051.1999998092651,"responseStart":1051.1999998092651,"secureConnectionStart":906.5},{"duration":110.69999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1161.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1161.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1272.1999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":110.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/50bc9be5bfead1a25e72c1a9338c94f6-CDN/lu2cib/820016/12ta74/e108c7645258ccb43280ed3404e3e949/_/download/contextbatch/css/com.atlassian.jira.plugins.jira-development-integration-plugin:0,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1162,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1162,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1272.5,"responseStart":0,"secureConnectionStart":0},{"duration":188.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1162.6999998092651,"connectEnd":1162.6999998092651,"connectStart":1162.6999998092651,"domainLookupEnd":1162.6999998092651,"domainLookupStart":1162.6999998092651,"fetchStart":1162.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":1162.6999998092651,"responseEnd":1351,"responseStart":1351,"secureConnectionStart":1162.6999998092651},{"duration":203.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":1163.1999998092651,"connectEnd":1163.1999998092651,"connectStart":1163.1999998092651,"domainLookupEnd":1163.1999998092651,"domainLookupStart":1163.1999998092651,"fetchStart":1163.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":1163.1999998092651,"responseEnd":1366.5,"responseStart":1366.5,"secureConnectionStart":1163.1999998092651},{"duration":233.39999961853027,"initiatorType":"script","name":"https://jira.mariadb.org/s/e0bf5781d46ea69fb123572974cf39de-CDN/lu2cib/820016/12ta74/e108c7645258ccb43280ed3404e3e949/_/download/contextbatch/js/com.atlassian.jira.plugins.jira-development-integration-plugin:0,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":1163.5,"connectEnd":1163.5,"connectStart":1163.5,"domainLookupEnd":1163.5,"domainLookupStart":1163.5,"fetchStart":1163.5,"redirectEnd":0,"redirectStart":0,"requestStart":1163.5,"responseEnd":1396.8999996185303,"responseStart":1396.8999996185303,"secureConnectionStart":1163.5}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":77,"responseStart":496,"responseEnd":504,"domLoading":499,"domInteractive":1398,"domContentLoadedEventStart":1398,"domContentLoadedEventEnd":1439,"domComplete":1739,"loadEventStart":1739,"loadEventEnd":1740,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1379.8000001907349},{"name":"bigPipe.sidebar-id.end","time":1381},{"name":"bigPipe.activity-panel-pipe-id.start","time":1381.1999998092651},{"name":"bigPipe.activity-panel-pipe-id.end","time":1382.5},{"name":"activityTabFullyLoaded","time":1461.0999994277954}],"measures":[],"correlationId":"497e3651658fbc","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":98,"dbReadsTimeInMs":12,"dbConnsTimeInMs":21,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
thiru, please fix this in 10.1. Maybe we can simply make the variable uint and adjust the primitives accordingly.