Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15205

Remove mysql_type_to_time_type()

Details

    Description

      We have a function:

      static inline enum enum_mysql_timestamp_type
      		 
      mysql_type_to_time_type(enum enum_field_types mysql_type)
      		 
      {
      		 
        switch(mysql_type) {
      		 
        case MYSQL_TYPE_TIME2:
      		 
        case MYSQL_TYPE_TIME: return MYSQL_TIMESTAMP_TIME;
      		 
        case MYSQL_TYPE_TIMESTAMP2:
      		 
        case MYSQL_TYPE_TIMESTAMP:
      		 
        case MYSQL_TYPE_DATETIME2:
      		 
        case MYSQL_TYPE_DATETIME: return MYSQL_TIMESTAMP_DATETIME;
      		 
        case MYSQL_TYPE_NEWDATE:
      		 
        case MYSQL_TYPE_DATE: return MYSQL_TIMESTAMP_DATE;
      		 
        default: return MYSQL_TIMESTAMP_ERROR;
      		 
        }
      		 
      }

      This is not friendly to pluggable data types.
      We'll remove this function and will use
      Type_handler::mysql_timestamp_type() instead.

      Attachments

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-4912 Data type plugin API version 1

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-8894 Inserting fractional seconds into MySQL 5.6 master breaks consistency on MariaDB 10 slave

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            Description We have a function:

            {code:sql}
            static inline enum enum_mysql_timestamp_type
            mysql_type_to_time_type(enum enum_field_types mysql_type)
            {
              switch(mysql_type) {
              case MYSQL_TYPE_TIME2:
              case MYSQL_TYPE_TIME: return MYSQL_TIMESTAMP_TIME;
              case MYSQL_TYPE_TIMESTAMP2:
              case MYSQL_TYPE_TIMESTAMP:
              case MYSQL_TYPE_DATETIME2:
              case MYSQL_TYPE_DATETIME: return MYSQL_TIMESTAMP_DATETIME;
              case MYSQL_TYPE_NEWDATE:
              case MYSQL_TYPE_DATE: return MYSQL_TIMESTAMP_DATE;
              default: return MYSQL_TIMESTAMP_ERROR;
              }
            }

            This is not friendly to pluggable data types.
            We'll remove this function and will use
            Type_handler::mysql_timestamp_type() instead.
            		We have a function:

            {code:cpp}
            static inline enum enum_mysql_timestamp_type
            mysql_type_to_time_type(enum enum_field_types mysql_type)
            {
              switch(mysql_type) {
              case MYSQL_TYPE_TIME2:
              case MYSQL_TYPE_TIME: return MYSQL_TIMESTAMP_TIME;
              case MYSQL_TYPE_TIMESTAMP2:
              case MYSQL_TYPE_TIMESTAMP:
              case MYSQL_TYPE_DATETIME2:
              case MYSQL_TYPE_DATETIME: return MYSQL_TIMESTAMP_DATETIME;
              case MYSQL_TYPE_NEWDATE:
              case MYSQL_TYPE_DATE: return MYSQL_TIMESTAMP_DATE;
              default: return MYSQL_TIMESTAMP_ERROR;
              }
            }
            {code}

            This is not friendly to pluggable data types.
            We'll remove this function and will use
            Type_handler::mysql_timestamp_type() instead.
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            bar Alexander Barkov added a comment -

            Pushed to bb-10.2-ext

            bar Alexander Barkov added a comment - Pushed to bb-10.2-ext
            bar Alexander Barkov made changes -
            issue.field.resolutiondate 2018-02-04 18:58:06.0 2018-02-04 18:58:06.447
            bar Alexander Barkov made changes -
            Fix Version/s 10.3.5 [ 22905 ]
            Fix Version/s 10.3 [ 22126 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 85414 ] MariaDB v4 [ 153734 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.