Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15205

Remove mysql_type_to_time_type()

    XMLWordPrintable

    Details

      Description

      We have a function:

      static inline enum enum_mysql_timestamp_type
      mysql_type_to_time_type(enum enum_field_types mysql_type)
      {
        switch(mysql_type) {
        case MYSQL_TYPE_TIME2:
        case MYSQL_TYPE_TIME: return MYSQL_TIMESTAMP_TIME;
        case MYSQL_TYPE_TIMESTAMP2:
        case MYSQL_TYPE_TIMESTAMP:
        case MYSQL_TYPE_DATETIME2:
        case MYSQL_TYPE_DATETIME: return MYSQL_TIMESTAMP_DATETIME;
        case MYSQL_TYPE_NEWDATE:
        case MYSQL_TYPE_DATE: return MYSQL_TIMESTAMP_DATE;
        default: return MYSQL_TIMESTAMP_ERROR;
        }
      }
      

      This is not friendly to pluggable data types.
      We'll remove this function and will use
      Type_handler::mysql_timestamp_type() instead.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              bar Alexander Barkov
              Reporter:
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: