-
Task
-
-
Major
-
Resolution:
Fixed
-
-
-
There are two parallel implementations for the same thing - detection if an Item has a subquery, directly or recursively, e.g. via arguments etc.
- A memmber Item::with_subselect, which is set in constructors and/or during fix_fields()
- A virtual method Item::has_subquery()
We'll remove Item::with_subselect and use the virtual implementation all around the code.
Rationale:
1. Get rid of duplicate functionality
2 With virtual implementation it will be easier to follow:
- which Item subclasses always have a subquery (e.g. Item_subselect)
- which Item subclasses can have a subquery
- which Item subclasses can never have a subquery
{"report":{"fcp":748,"ttfb":190.09999999403954,"pageVisibility":"visible","entityId":64488,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"30f11501-774a-4be8-aaa4-6b82655043c0","navigationType":0,"readyForUser":810.0999999940395,"redirectCount":0,"resourceLoadedEnd":809.9000000059605,"resourceLoadedStart":195.19999998807907,"resourceTiming":[{"duration":15.099999994039536,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":195.19999998807907,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":195.19999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":210.2999999821186,"responseStart":0,"secureConnectionStart":0},{"duration":15.399999976158142,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":195.40000000596046,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":195.40000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":210.7999999821186,"responseStart":0,"secureConnectionStart":0},{"duration":100.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/e9b27a47da5fb0f74a35acd57e9847fb-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":195.59999999403954,"connectEnd":195.59999999403954,"connectStart":195.59999999403954,"domainLookupEnd":195.59999999403954,"domainLookupStart":195.59999999403954,"fetchStart":195.59999999403954,"redirectEnd":0,"redirectStart":0,"requestStart":195.59999999403954,"responseEnd":296.09999999403954,"responseStart":296.09999999403954,"secureConnectionStart":195.59999999403954},{"duration":125.10000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/s/c32eb0da7ad9831253f8397e6cc26afd-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":195.7999999821186,"connectEnd":195.7999999821186,"connectStart":195.7999999821186,"domainLookupEnd":195.7999999821186,"domainLookupStart":195.7999999821186,"fetchStart":195.7999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":195.7999999821186,"responseEnd":320.90000000596046,"responseStart":320.90000000596046,"secureConnectionStart":195.7999999821186},{"duration":129.09999999403954,"initiatorType":"script","name":"https://jira.mariadb.org/s/bc0bcb146314416123c992714ee00ff7-CDN/lu2bv2/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":195.90000000596046,"connectEnd":195.90000000596046,"connectStart":195.90000000596046,"domainLookupEnd":195.90000000596046,"domainLookupStart":195.90000000596046,"fetchStart":195.90000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":195.90000000596046,"responseEnd":325,"responseStart":325,"secureConnectionStart":195.90000000596046},{"duration":129.40000000596046,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":196.09999999403954,"connectEnd":196.09999999403954,"connectStart":196.09999999403954,"domainLookupEnd":196.09999999403954,"domainLookupStart":196.09999999403954,"fetchStart":196.09999999403954,"redirectEnd":0,"redirectStart":0,"requestStart":196.09999999403954,"responseEnd":325.5,"responseStart":325.5,"secureConnectionStart":196.09999999403954},{"duration":129.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":196.2999999821186,"connectEnd":196.2999999821186,"connectStart":196.2999999821186,"domainLookupEnd":196.2999999821186,"domainLookupStart":196.2999999821186,"fetchStart":196.2999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":196.2999999821186,"responseEnd":325.7999999821186,"responseStart":325.7999999821186,"secureConnectionStart":196.2999999821186},{"duration":130.19999998807907,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bv2/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":196.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":196.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":326.69999998807907,"responseStart":0,"secureConnectionStart":0},{"duration":129.59999999403954,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":196.69999998807907,"connectEnd":196.69999998807907,"connectStart":196.69999998807907,"domainLookupEnd":196.69999998807907,"domainLookupStart":196.69999998807907,"fetchStart":196.69999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":196.69999998807907,"responseEnd":326.2999999821186,"responseStart":326.2999999821186,"secureConnectionStart":196.69999998807907},{"duration":129.90000000596046,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":196.7999999821186,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":196.7999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":326.69999998807907,"responseStart":0,"secureConnectionStart":0},{"duration":129.7999999821186,"initiatorType":"script","name":"https://jira.mariadb.org/s/719848dd97ebe0663199f49a3936487a-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":197,"connectEnd":197,"connectStart":197,"domainLookupEnd":197,"domainLookupStart":197,"fetchStart":197,"redirectEnd":0,"redirectStart":0,"requestStart":197,"responseEnd":326.7999999821186,"responseStart":326.7999999821186,"secureConnectionStart":197},{"duration":355,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":197.7999999821186,"connectEnd":197.7999999821186,"connectStart":197.7999999821186,"domainLookupEnd":197.7999999821186,"domainLookupStart":197.7999999821186,"fetchStart":197.7999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":197.7999999821186,"responseEnd":552.7999999821186,"responseStart":552.7999999821186,"secureConnectionStart":197.7999999821186},{"duration":612.1000000238419,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":197.7999999821186,"connectEnd":197.7999999821186,"connectStart":197.7999999821186,"domainLookupEnd":197.7999999821186,"domainLookupStart":197.7999999821186,"fetchStart":197.7999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":197.7999999821186,"responseEnd":809.9000000059605,"responseStart":809.9000000059605,"secureConnectionStart":197.7999999821186},{"duration":237.60000002384186,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":513.2999999821186,"connectEnd":513.2999999821186,"connectStart":513.2999999821186,"domainLookupEnd":513.2999999821186,"domainLookupStart":513.2999999821186,"fetchStart":513.2999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":513.2999999821186,"responseEnd":750.9000000059605,"responseStart":750.9000000059605,"secureConnectionStart":513.2999999821186}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":50,"responseStart":190,"responseEnd":191,"domLoading":193,"domInteractive":859,"domContentLoadedEventStart":859,"domContentLoadedEventEnd":892,"domComplete":1978,"loadEventStart":1978,"loadEventEnd":1980,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":847.5999999940395},{"name":"bigPipe.sidebar-id.end","time":848.4000000059605},{"name":"bigPipe.activity-panel-pipe-id.start","time":848.5999999940395},{"name":"bigPipe.activity-panel-pipe-id.end","time":851},{"name":"activityTabFullyLoaded","time":901.5}],"measures":[],"correlationId":"f90bacff54ac9f","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":82,"dbReadsTimeInMs":8,"dbConnsTimeInMs":15,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}