Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-14494

Move set_param_xxx() in sql_prepare.cc to methods in Item_param and Type_handler

Details

    Description

      Under terms of this task we'll:

      • Change a virtual function pointer Item_param::set_param_func to a Type_handler based implementation, by adding a new virtual method Type_handler::Item_param_set_param_func()
      • Move static functions set_param_xxx() as methods to Item_param
      • Decompose the switch in setup_one_conversion_function() into a new virtual method Type_handler::Item_param_setup_conversion()

      Attachments

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-4912 Data type plugin API version 1

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-14467 Item_param: replace {INT|DECIMAL|REAL|STRING|TIME}_VALUE with Type_handler

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            Description Under terms of this task we'll:

            - Change a virtual function pointer Item_param::set_param_func
              to a Type_handler based implementation, by adding a new
              virtual method Type_handler::Item_param_set_param_func()

            - Move static functions set_param_xxx() as methods to Item_param

            - Decompose the switch setup_one_conversion_function() into
              a new virtual method Type_handler::Item_param_setup_conversion()
            bar Alexander Barkov made changes -
            Description Under terms of this task we'll:

            - Change a virtual function pointer Item_param::set_param_func
              to a Type_handler based implementation, by adding a new
              virtual method Type_handler::Item_param_set_param_func()

            - Move static functions set_param_xxx() as methods to Item_param

            - Decompose the switch setup_one_conversion_function() into
              a new virtual method Type_handler::Item_param_setup_conversion()
            		Under terms of this task we'll:

            - Change a virtual function pointer Item_param::set_param_func to a Type_handler based implementation, by adding a new virtual method Type_handler::Item_param_set_param_func()

            - Move static functions set_param_xxx() as methods to Item_param

            - Decompose the switch setup_one_conversion_function() into a new virtual method Type_handler::Item_param_setup_conversion()
            bar Alexander Barkov made changes -
            Description Under terms of this task we'll:

            - Change a virtual function pointer Item_param::set_param_func to a Type_handler based implementation, by adding a new virtual method Type_handler::Item_param_set_param_func()

            - Move static functions set_param_xxx() as methods to Item_param

            - Decompose the switch setup_one_conversion_function() into a new virtual method Type_handler::Item_param_setup_conversion()
            		Under terms of this task we'll:

            - Change a virtual function pointer Item_param::set_param_func to a Type_handler based implementation, by adding a new virtual method Type_handler::Item_param_set_param_func()

            - Move static functions set_param_xxx() as methods to Item_param

            - Decompose the {{switch}} in setup_one_conversion_function() into a new virtual method Type_handler::Item_param_setup_conversion()
            bar Alexander Barkov made changes -
            Description Under terms of this task we'll:

            - Change a virtual function pointer Item_param::set_param_func to a Type_handler based implementation, by adding a new virtual method Type_handler::Item_param_set_param_func()

            - Move static functions set_param_xxx() as methods to Item_param

            - Decompose the {{switch}} in setup_one_conversion_function() into a new virtual method Type_handler::Item_param_setup_conversion()
            		Under terms of this task we'll:

            - Change a virtual function pointer {{Item_param::set_param_func}} to a {{Type_handler}} based implementation, by adding a new virtual method {{Type_handler::Item_param_set_param_func()}}

            - Move static functions {{set_param_xxx()}} as methods to {{Item_param}}

            - Decompose the {{switch}} in {{setup_one_conversion_function()}} into a new virtual method {{Type_handler::Item_param_setup_conversion()}}
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            issue.field.resolutiondate 2017-11-24 08:44:09.0 2017-11-24 08:44:09.454
            bar Alexander Barkov made changes -
            Fix Version/s 10.3.3 [ 22644 ]
            Fix Version/s 10.3 [ 22126 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 84082 ] MariaDB v4 [ 133406 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.