[MDEV-14246] Skip the ha_innobase::prepare_inplace_alter_table() phase if no inplace_alter_table() phase is needed - Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.0(EOL), 10.1(EOL), 10.2(EOL), 10.3(EOL)
Fix Version/s: 10.3.7
Component/s: Storage Engine - InnoDB
Labels:
- ddl
- instant
- performance

Description

In the ALGORITHM=INPLACE API, if the operation involves data changes, such as adding an index or rebuilding the table, it will be necessary to invoke a "prepare" phase followed by a data transformation phase.

Currently, the "prepare" phase is unnecessarily being executed for instant ADD COLUMN (~~MDEV-11369~~) and possibly other operations. This causes an unnecessary step to acquire and downgrade an exclusive meta-data lock, before upgrading the lock to exclusive again for executing ha_innobase::commit_inplace_alter_table().

Attachments

Issue Links

duplicates

MDEV-13134 Introduce ALTER TABLE attributes ALGORITHM=NOCOPY and ALGORITHM=INSTANT

Closed

relates to

MDEV-11369 Instant add column for InnoDB

Closed

MDEV-13134 Introduce ALTER TABLE attributes ALGORITHM=NOCOPY and ALGORITHM=INSTANT

Closed

MDEV-14016 Allow instant ADD COLUMN, ADD INDEX, LOCK=NONE

Closed

Activity

People

Assignee:: Thirunarayanan Balathandayuthapani

Reporter:: Marko Mäkelä

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2017-11-01 20:35

Updated:: 2018-05-07 10:31

Resolved:: 2018-05-07 10:31

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.