[MDEV-14219] Allow online table rebuild when encryption or compression parameters change - Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.1.0, 10.2.0, 10.3.0
Fix Version/s: 10.1.29, 10.2.11, 10.3.3
Component/s: Storage Engine - InnoDB, Storage Engine - XtraDB
Labels:

Description

When MariaDB 10.1.0 introduced table options for encryption and compression, it unnecessarily changed ha_innobase::check_if_supported_inplace_alter() so that ALGORITHM=COPY is forced when these parameters differ.
A better solution would be to move the check to innobase_need_rebuild(). In that way, the ALGORITHM=INPLACE interface (yes, the syntax is very misleading) can be used for rebuilding the table much more efficiently, with merge sort, with no undo logging, and allowing concurrent DML operations.

Attachments

Issue Links

causes

MDEV-15116 Wrong error code/message 1478: 'Table storage engine 'InnoDB' does not support the create option 'ENCRYPTION_KEY_ID'

Open

is duplicated by

MDEV-13639 Server crashes in prepare_inplace_alter_table_dict upon altering a table with discarded tablespace

Closed

MDEV-13865 InnoDB unnecessarily uses ALGORITHM=COPY when changing table options

Closed

relates to

MDEV-14016 Allow instant ADD COLUMN, ADD INDEX, LOCK=NONE

Closed

Activity

People

Assignee:: Marko Mäkelä

Reporter:: Marko Mäkelä

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2017-10-30 13:42

Updated:: 2021-10-26 08:17

Resolved:: 2017-10-31 11:48

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.