My intention was to remove the option, because it is documented as related to the .xbcrypt files. Perhaps at that time, I wrongly thought Mariabackup would also remove the support for qpress.
- {"remove-original", OPT_REMOVE_ORIGINAL, "Remove .qp and .xbcrypt files "
|
- "after decryption and decompression.",
|
- (uchar *) &opt_remove_original,
|
- (uchar *) &opt_remove_original,
|
- 0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0, 0},
|
I now see that I failed to remove the constant OPT_REMOVE_ORIGINAL and some references to the variable opt_remove_original (which is always FALSE).
It looks like Mariabackup does support .qp files, but by using an external program, qpress.
So, the proper fix would seem to reinstate the lines mentioned above, but remove the reference to .xbcrypt or decryption.
(MariaDB 10.1 supports encrypted data and log files. If you want encryption, you should enable the server options and let Mariabackup deal with the encrypted files directly.)
wlad it is claimed that mariabackup is based on 2.3.8 and indeed the option is in upstream https://github.com/percona/percona-xtrabackup/blob/percona-xtrabackup-2.3.8/storage/innobase/xtrabackup/src/xtrabackup.cc#L936 , but not in our source https://github.com/MariaDB/server/blob/10.1/extra/mariabackup/xtrabackup.cc#L817 https://github.com/MariaDB/server/blob/10.2/extra/mariabackup/xtrabackup.cc#L817 , thus I mark this as verified