Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-14024

PCRE2

Details

    • Task
    • Status: Closed (View Workflow)
    • Critical
    • Resolution: Fixed
    • 10.5.1
    • OTHER
    • None
    • 10.3.3-1

    Description

      PCRE1 is in maintenance mode, some bugs aren't getting fixed (see https://bugs.exim.org/show_bug.cgi?id=2173). The current PCRE branch is PCRE2, we need to migrate to it to continue getting our reported bugs fixed.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-13412 main.func_regexp_pcre fails in buildbot on ppc64le: server crash or wrong result

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-16599 Add REGEXP_LIKE function

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20377 Make WITH_MSAN more usable

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31061 ASAN: global-buffer-overflow in __interceptor_regcomp.part.0 and UBSAN: runtime error: applying non-zero offset -999 to null pointer in pcre/pcre_exec.c

          • Major - Major loss of function.
          • Closed
          links to

          Web Link Bug 2173 - stack frame size detection is broken

          Activity

            Ascending order - Click to sort in descending order
            holyfoot Alexey Botchkov added a comment -

            So that i removed the pcre/ subdirectory, added the pcre2/ subdirectory with the pcre2-10.31 sources, and then did these changes to the server code:
            http://lists.askmonty.org/pipermail/commits/2018-April/012175.html

            holyfoot Alexey Botchkov added a comment - So that i removed the pcre/ subdirectory, added the pcre2/ subdirectory with the pcre2-10.31 sources, and then did these changes to the server code: http://lists.askmonty.org/pipermail/commits/2018-April/012175.html
            serg Sergei Golubchik added a comment -

            the first commit (remove pcre, add prce2) — did you do any changes to pcre2? or just unpacked the tarball?

            serg Sergei Golubchik added a comment - the first commit (remove pcre, add prce2) — did you do any changes to pcre2? or just unpacked the tarball?
            holyfoot Alexey Botchkov added a comment -

            I just unpacked the tarball.

            holyfoot Alexey Botchkov added a comment - I just unpacked the tarball.
            holyfoot Alexey Botchkov added a comment -

            http://lists.askmonty.org/pipermail/commits/2018-April/012444.html

            holyfoot Alexey Botchkov added a comment - http://lists.askmonty.org/pipermail/commits/2018-April/012444.html
            holyfoot Alexey Botchkov added a comment -

            patch v2
            http://lists.askmonty.org/pipermail/commits/2018-June/012656.html

            holyfoot Alexey Botchkov added a comment - patch v2 http://lists.askmonty.org/pipermail/commits/2018-June/012656.html
            serg Sergei Golubchik added a comment -

            review sent

            serg Sergei Golubchik added a comment - review sent
            marko Marko Mäkelä added a comment -

            As noted in MDEV-20377, MemorySanitizer is finding several issues with the bundled PCRE1 (and according to serg the "libpcre3" on my Debian system actually is PCRE1). Also, I remember AddressSanitizer flagging issues when using -DWITH_PCRE=bundled. Using -DWITH_PCRE=system could merely hide those issues from ASAN.

            I feel that this issue is all but blocking the use of MemorySanitizer.

            marko Marko Mäkelä added a comment - As noted in MDEV-20377 , MemorySanitizer is finding several issues with the bundled PCRE1 (and according to serg the " libpcre3 " on my Debian system actually is PCRE1). Also, I remember AddressSanitizer flagging issues when using -DWITH_PCRE=bundled . Using -DWITH_PCRE=system could merely hide those issues from ASAN. I feel that this issue is all but blocking the use of MemorySanitizer.

            People

              serg Sergei Golubchik
              serg Sergei Golubchik
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.