Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-13963

storage/tokudb/PerconaFT/ft/serialize/ft-serialize.cc:419: suspicious switch statement ?

Details

    Description

      Source code is

          switch (version) {
      		 
              case FT_LAYOUT_VERSION_29:
      		 
                  size += sizeof(uint64_t);  // logrows in ft
      		 
              case FT_LAYOUT_VERSION_28:
      		 
                  size += sizeof(uint32_t);  // fanout in ft
      		 
              case FT_LAYOUT_VERSION_27:
      		 
              case FT_LAYOUT_VERSION_26:

      Maybe some missing break statements here. Either that or some missing comments
      saying the fallthrough is deliberate.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          elenst Elena Stepanova added a comment -

          That's how it is in the upstream code:
          https://github.com/Tokutek/ft-index/blob/master/ft/serialize/ft-serialize.cc

          Could you please report it to them?

          elenst Elena Stepanova added a comment - That's how it is in the upstream code: https://github.com/Tokutek/ft-index/blob/master/ft/serialize/ft-serialize.cc Could you please report it to them?
          dcb David Binderman added a comment -

          >Could you please report it to them?

          Done.

          https://github.com/Tokutek/ft-index/issues/2

          dcb David Binderman added a comment - >Could you please report it to them? Done. https://github.com/Tokutek/ft-index/issues/2
          philsweeney Phil Sweeney added a comment -

          dcb You might need to report it to jira.percona.com as I think that's where they track PerconaFT and TokuDB issues. https://jira.percona.com/projects/TDB/issues/TDB-28?filter=allopenissues Those tokutek github entries are old as Percona bought Tokutek a while back.

          philsweeney Phil Sweeney added a comment - dcb You might need to report it to jira.percona.com as I think that's where they track PerconaFT and TokuDB issues. https://jira.percona.com/projects/TDB/issues/TDB-28?filter=allopenissues Those tokutek github entries are old as Percona bought Tokutek a while back.
          elenst Elena Stepanova added a comment -

          Right, sorry for not specifying it earlier. It doesn't appear that their github tracker is in use, recently all the activity has been happening at JIRA. Hopefully they still receive and re-file issues reported at github, but I'm not quite sure about that.

          elenst Elena Stepanova added a comment - Right, sorry for not specifying it earlier. It doesn't appear that their github tracker is in use, recently all the activity has been happening at JIRA. Hopefully they still receive and re-file issues reported at github, but I'm not quite sure about that.
          dcb David Binderman added a comment -

          >You might need to report it to jira.percona.com

          Thanks for the invite, but I don't think I'll bother.

          I am happy for someone else to report it.

          dcb David Binderman added a comment - >You might need to report it to jira.percona.com Thanks for the invite, but I don't think I'll bother. I am happy for someone else to report it.
          elenst Elena Stepanova added a comment -

          Weird, the issue from github seems to be gone, but nothing appeared in JIRA. I've now re-filed it as https://jira.percona.com/browse/TDB-78 .

          elenst Elena Stepanova added a comment - Weird, the issue from github seems to be gone, but nothing appeared in JIRA. I've now re-filed it as https://jira.percona.com/browse/TDB-78 .

          People

            Unassigned Unassigned
            dcb David Binderman
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.