[MDEV-13963] storage/tokudb/PerconaFT/ft/serialize/ft-serialize.cc:419: suspicious switch statement ? Created: 2017-09-29  Updated: 2022-01-06

Status: Open
Project: MariaDB Server
Component/s: Compiling
Affects Version/s: 10.2.9
Fix Version/s: 10.2

Type: Bug Priority: Minor
Reporter: David Binderman Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: cppcheck, upstream


 Description   

Source code is

    switch (version) {
 
        case FT_LAYOUT_VERSION_29:
 
            size += sizeof(uint64_t);  // logrows in ft
 
        case FT_LAYOUT_VERSION_28:
 
            size += sizeof(uint32_t);  // fanout in ft
 
        case FT_LAYOUT_VERSION_27:
 
        case FT_LAYOUT_VERSION_26:

Maybe some missing break statements here. Either that or some missing comments
saying the fallthrough is deliberate.

 Comments   
Comment by Elena Stepanova [ 2017-10-01 ]

That's how it is in the upstream code:
https://github.com/Tokutek/ft-index/blob/master/ft/serialize/ft-serialize.cc

Could you please report it to them?

Comment by David Binderman [ 2017-10-01 ]

>Could you please report it to them?

Done.

https://github.com/Tokutek/ft-index/issues/2

Comment by Phil Sweeney [ 2017-10-01 ]

dcb You might need to report it to jira.percona.com as I think that's where they track PerconaFT and TokuDB issues. https://jira.percona.com/projects/TDB/issues/TDB-28?filter=allopenissues Those tokutek github entries are old as Percona bought Tokutek a while back.

Comment by Elena Stepanova [ 2017-10-01 ]

Right, sorry for not specifying it earlier. It doesn't appear that their github tracker is in use, recently all the activity has been happening at JIRA. Hopefully they still receive and re-file issues reported at github, but I'm not quite sure about that.

Comment by David Binderman [ 2017-10-01 ]

>You might need to report it to jira.percona.com

Thanks for the invite, but I don't think I'll bother.

I am happy for someone else to report it.

Comment by Elena Stepanova [ 2017-10-01 ]

Weird, the issue from github seems to be gone, but nothing appeared in JIRA. I've now re-filed it as https://jira.percona.com/browse/TDB-78 .

Generated at Thu Feb 08 08:09:46 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.