[MDEV-13690] Remove unnecessary innodb_use_mtflush, innodb_mtflush_threads parameters and related code - Jira

Details

Type: Task
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Fix Version/s: 10.3.2
Component/s: Storage Engine - InnoDB
Labels:
None

Attachments

Issue Links

is blocked by

MDEV-13674 Deprecate innodb_use_mtflush and innodb_mtflush_threads

Closed

relates to

MDEV-13444 assertion mtflush_io != NULL on exit with innodb-use-mtflush

Closed

MDEV-25003 mtflush_service_io - workitem status is always SUCCESS even if pool flush fails

Closed

Activity

Ascending order - Click to sort in descending order

Jan Lindström (Inactive) created issue - 2017-08-31 10:35

Jan Lindström (Inactive) made changes - 2017-08-31 10:36

Field	Original Value	New Value
Link		This issue is blocked by ~~MDEV-13674~~ [ ~~MDEV-13674~~ ]

Jan Lindström (Inactive) made changes - 2017-08-31 11:19

Status

Open [ 1 ]

In Progress [ 3 ]

Jan Lindström (Inactive) made changes - 2017-09-01 08:45

Affects Version/s	10.3 [ 22126 ]
Issue Type	Bug [ 1 ]	Task [ 3 ]

Jan Lindström (Inactive) added a comment - 2017-09-01 09:49

http://lists.askmonty.org/pipermail/commits/2017-September/011436.html

Jan Lindström (Inactive) added a comment - 2017-09-01 09:49 http://lists.askmonty.org/pipermail/commits/2017-September/011436.html

Jan Lindström (Inactive) made changes - 2017-09-01 09:49

Assignee	Jan Lindström [ jplindst ]	Marko Mäkelä [ marko ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Jan Lindström (Inactive) added a comment - 2017-09-01 09:50

greenman Can you update KB that from 10.2.9 these variables are deprecated and from 10.3.2 these variables are removed.

Jan Lindström (Inactive) added a comment - 2017-09-01 09:50 greenman Can you update KB that from 10.2.9 these variables are deprecated and from 10.3.2 these variables are removed.

Jan Lindström (Inactive) added a comment - 2017-09-01 09:50

greenman Can you update KB that from 10.2.9 these variables are deprecated and from 10.3.2 these variables are removed.

Jan Lindström (Inactive) added a comment - 2017-09-01 09:50 greenman Can you update KB that from 10.2.9 these variables are deprecated and from 10.3.2 these variables are removed.

Ian Gilfillan added a comment - 2017-09-01 09:59

Done, https://mariadb.com/kb/en/the-mariadb-library/xtradbinnodb-server-system-variables/ has been updated, will add to version release notes as well.

Ian Gilfillan added a comment - 2017-09-01 09:59 Done, https://mariadb.com/kb/en/the-mariadb-library/xtradbinnodb-server-system-variables/ has been updated, will add to version release notes as well.

Marko Mäkelä added a comment - 2017-09-01 11:47

Looks OK, but please apply also this:

diff --git a/mysql-test/suite/sys_vars/r/sysvars_innodb,32bit.rdiff b/mysql-test/suite/sys_vars/r/sysvars_innodb,32bit.rdiff

index 46d6d7b30a4..27cead59b58 100644

--- a/mysql-test/suite/sys_vars/r/sysvars_innodb,32bit.rdiff

+++ b/mysql-test/suite/sys_vars/r/sysvars_innodb,32bit.rdiff

@@ -364,15 +364,6 @@

  VARIABLE_COMMENT	Maximum delay of user threads in micro-seconds

  NUMERIC_MIN_VALUE	0

  NUMERIC_MAX_VALUE	10000000

-@@ -1636,7 +1636,7 @@

- GLOBAL_VALUE_ORIGIN	COMPILE-TIME

- DEFAULT_VALUE	8

- VARIABLE_SCOPE	GLOBAL

--VARIABLE_TYPE	BIGINT

-+VARIABLE_TYPE	INT

- VARIABLE_COMMENT	DEPRECATED. Number of multi-threaded flush threads

- NUMERIC_MIN_VALUE	1

- NUMERIC_MAX_VALUE	64

 @@ -1692,10 +1692,10 @@

  GLOBAL_VALUE_ORIGIN	COMPILE-TIME

  DEFAULT_VALUE	0

Marko Mäkelä added a comment - 2017-09-01 11:47 Looks OK, but please apply also this: diff --git a/mysql-test/suite/sys_vars/r/sysvars_innodb,32bit.rdiff b/mysql-test/suite/sys_vars/r/sysvars_innodb,32bit.rdiff index 46d6d7b30a4..27cead59b58 100644 --- a/mysql-test/suite/sys_vars/r/sysvars_innodb,32bit.rdiff +++ b/mysql-test/suite/sys_vars/r/sysvars_innodb,32bit.rdiff @@ -364,15 +364,6 @@ VARIABLE_COMMENT Maximum delay of user threads in micro-seconds NUMERIC_MIN_VALUE 0 NUMERIC_MAX_VALUE 10000000 -@@ -1636,7 +1636,7 @@ - GLOBAL_VALUE_ORIGIN COMPILE-TIME - DEFAULT_VALUE 8 - VARIABLE_SCOPE GLOBAL --VARIABLE_TYPE BIGINT -+VARIABLE_TYPE INT - VARIABLE_COMMENT DEPRECATED. Number of multi-threaded flush threads - NUMERIC_MIN_VALUE 1 - NUMERIC_MAX_VALUE 64 @@ -1692,10 +1692,10 @@ GLOBAL_VALUE_ORIGIN COMPILE-TIME DEFAULT_VALUE 0

Marko Mäkelä made changes - 2017-09-01 11:47

Assignee	Marko Mäkelä [ marko ]	Jan Lindström [ jplindst ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Jan Lindström (Inactive) made changes - 2017-09-01 15:36

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Jan Lindström (Inactive) added a comment - 2017-09-01 15:37

commit 016c35a7f2f4a288542f5fcb0e182c05238398e6
Author: Jan Lindström <jan.lindstrom@mariadb.com>
Date: Fri Sep 1 18:33:46 2017 +0300

~~MDEV-13690~~: Remove unnecessary innodb_use_mtflush, innodb_mtflush_threads parameters and related code

Users can use innodb-page-cleaners instead.

Jan Lindström (Inactive) added a comment - 2017-09-01 15:37 commit 016c35a7f2f4a288542f5fcb0e182c05238398e6 Author: Jan Lindström <jan.lindstrom@mariadb.com> Date: Fri Sep 1 18:33:46 2017 +0300 MDEV-13690 : Remove unnecessary innodb_use_mtflush, innodb_mtflush_threads parameters and related code Users can use innodb-page-cleaners instead.

Jan Lindström (Inactive) made changes - 2017-09-01 15:37

Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Closed [ 6 ]

Marko Mäkelä made changes - 2021-04-26 12:56

Link

This issue relates to ~~MDEV-25003~~ [ ~~MDEV-25003~~ ]

Marko Mäkelä made changes - 2021-10-25 14:01

Link

This issue relates to ~~MDEV-13444~~ [ ~~MDEV-13444~~ ]

Sergei Golubchik made changes - 2021-12-06 21:23

Workflow

MariaDB v3 [ 82336 ]

MariaDB v4 [ 133336 ]

People

Assignee:: Jan Lindström (Inactive)

Reporter:: Jan Lindström (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 2017-08-31 10:35

Updated:: 2021-10-25 14:01

Resolved:: 2017-09-01 15:37

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server