Sprint:
10.2.2-3, 10.2.2-1, 10.2.2-2, 10.2.2-4, 10.1.18
This task is a part of MDEV-10591 Oracle-style packages.
In order for packages to reuse all routine features, such as:
package-wide variables, exceptions, cursors, etc
package executable initialization block
under terms of MDEV-10591 we'll introduce new classes (with proposed names Package and Package_body )
and derived these classes from sp_head .
To simplify initialization of the Package* instances, we need to move most the code from sp_head::init to sp_head::sp_head .
The relevant code:
sp_head::init(LEX *lex)
{
...
m_param_begin= NULL;
m_param_end= NULL;
m_body_begin= NULL ;
m_qname.str= NULL;
m_qname.length= 0;
m_explicit_name= false ;
m_db.str= NULL;
m_db.length= 0;
m_name.str= NULL;
m_name.length= 0;
m_params.str= NULL;
m_params.length= 0;
m_body.str= NULL;
m_body.length= 0;
m_defstr.str= NULL;
m_defstr.length= 0;
m_return_field_def.charset= NULL;
...
}
Currently new instances of sp_head are created by LEX::make_sp_head , in this code:
...
if ((sp= new sp_head(type)))
{
sp->reset_thd_mem_root(thd);
sp->init(this);
...
Notice, the constructor call in new is immediately followed by init(this) .
After this task, the above members will be initialized in the constructor rather than in init() .
Transition
Time In Source Status
Execution Times
Open
In Progress
2m 9s
1
In Progress
Closed
35d 2h 29m
1
{"report":{"fcp":1049.6999998092651,"ttfb":409.90000009536743,"pageVisibility":"visible","entityId":62233,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"c1e1f5b0-f5b5-4aa5-8939-895172193f03","navigationType":0,"readyForUser":1131.8000001907349,"redirectCount":0,"resourceLoadedEnd":1358.5999999046326,"resourceLoadedStart":415.5,"resourceTiming":[{"duration":106.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":415.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":415.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":522,"responseStart":0,"secureConnectionStart":0},{"duration":108.09999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":415.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":415.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":523.9000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":161.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":416,"connectEnd":416,"connectStart":416,"domainLookupEnd":416,"domainLookupStart":416,"fetchStart":416,"redirectEnd":0,"redirectStart":0,"requestStart":416,"responseEnd":577.3000001907349,"responseStart":577.3000001907349,"secureConnectionStart":416},{"duration":239.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":416.19999980926514,"connectEnd":416.19999980926514,"connectStart":416.19999980926514,"domainLookupEnd":416.19999980926514,"domainLookupStart":416.19999980926514,"fetchStart":416.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":416.19999980926514,"responseEnd":656.0999999046326,"responseStart":656.0999999046326,"secureConnectionStart":416.19999980926514},{"duration":243.7999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":416.40000009536743,"connectEnd":416.40000009536743,"connectStart":416.40000009536743,"domainLookupEnd":416.40000009536743,"domainLookupStart":416.40000009536743,"fetchStart":416.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":416.40000009536743,"responseEnd":660.1999998092651,"responseStart":660.1999998092651,"secureConnectionStart":416.40000009536743},{"duration":244.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":416.59999990463257,"connectEnd":416.59999990463257,"connectStart":416.59999990463257,"domainLookupEnd":416.59999990463257,"domainLookupStart":416.59999990463257,"fetchStart":416.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":416.59999990463257,"responseEnd":660.6999998092651,"responseStart":660.6999998092651,"secureConnectionStart":416.59999990463257},{"duration":244.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":416.80000019073486,"connectEnd":416.80000019073486,"connectStart":416.80000019073486,"domainLookupEnd":416.80000019073486,"domainLookupStart":416.80000019073486,"fetchStart":416.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":416.80000019073486,"responseEnd":661,"responseStart":661,"secureConnectionStart":416.80000019073486},{"duration":304.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":417,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":417,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":721.4000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":244.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":417.19999980926514,"connectEnd":417.19999980926514,"connectStart":417.19999980926514,"domainLookupEnd":417.19999980926514,"domainLookupStart":417.19999980926514,"fetchStart":417.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":417.19999980926514,"responseEnd":661.5,"responseStart":661.5,"secureConnectionStart":417.19999980926514},{"duration":304.09999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":417.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":417.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":721.5,"responseStart":0,"secureConnectionStart":0},{"duration":244.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":417.5,"connectEnd":417.5,"connectStart":417.5,"domainLookupEnd":417.5,"domainLookupStart":417.5,"fetchStart":417.5,"redirectEnd":0,"redirectStart":0,"requestStart":417.5,"responseEnd":661.9000000953674,"responseStart":661.9000000953674,"secureConnectionStart":417.5},{"duration":494.7999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":426.80000019073486,"connectEnd":426.80000019073486,"connectStart":426.80000019073486,"domainLookupEnd":426.80000019073486,"domainLookupStart":426.80000019073486,"fetchStart":426.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":426.80000019073486,"responseEnd":921.5999999046326,"responseStart":921.5999999046326,"secureConnectionStart":426.80000019073486},{"duration":908,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":426.90000009536743,"connectEnd":426.90000009536743,"connectStart":426.90000009536743,"domainLookupEnd":426.90000009536743,"domainLookupStart":426.90000009536743,"fetchStart":426.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":426.90000009536743,"responseEnd":1334.9000000953674,"responseStart":1334.9000000953674,"secureConnectionStart":426.90000009536743},{"duration":181.59999990463257,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":740.3000001907349,"connectEnd":740.3000001907349,"connectStart":740.3000001907349,"domainLookupEnd":740.3000001907349,"domainLookupStart":740.3000001907349,"fetchStart":740.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":740.3000001907349,"responseEnd":921.9000000953674,"responseStart":921.9000000953674,"secureConnectionStart":740.3000001907349},{"duration":355.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1003.1999998092651,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1003.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1358.5999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":338.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1004.1999998092651,"connectEnd":1004.1999998092651,"connectStart":1004.1999998092651,"domainLookupEnd":1004.1999998092651,"domainLookupStart":1004.1999998092651,"fetchStart":1004.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":1004.1999998092651,"responseEnd":1342.5999999046326,"responseStart":1342.5999999046326,"secureConnectionStart":1004.1999998092651},{"duration":345,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":1004.5,"connectEnd":1004.5,"connectStart":1004.5,"domainLookupEnd":1004.5,"domainLookupStart":1004.5,"fetchStart":1004.5,"redirectEnd":0,"redirectStart":0,"requestStart":1004.5,"responseEnd":1349.5,"responseStart":1349.5,"secureConnectionStart":1004.5},{"duration":317.30000019073486,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1043.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1043.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1360.8000001907349,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":233,"responseStart":410,"responseEnd":416,"domLoading":414,"domInteractive":1393,"domContentLoadedEventStart":1393,"domContentLoadedEventEnd":1437,"domComplete":1853,"loadEventStart":1853,"loadEventEnd":1854,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1367.0999999046326},{"name":"bigPipe.sidebar-id.end","time":1367.9000000953674},{"name":"bigPipe.activity-panel-pipe-id.start","time":1368.1999998092651},{"name":"bigPipe.activity-panel-pipe-id.end","time":1369.1999998092651},{"name":"activityTabFullyLoaded","time":1452.4000000953674}],"measures":[],"correlationId":"af3ee792127b4d","effectiveType":"4g","downlink":9.8,"rtt":0,"serverDuration":109,"dbReadsTimeInMs":20,"dbConnsTimeInMs":30,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}