Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Duplicate
-
10.0(EOL), 10.1(EOL), 10.2(EOL)
Description
server/debian/mariadb-server-10.x.mysql-server.logrotate
line 14: if [ -f `my_print_defaults --mysqld | grep -oP "pid-file=\K[^$]+"` ]; then
this always fails in GNU grep v. 22.4 because of:
_*$ echo $ | grep -Pz $
grep: unescaped $ or $ not supported with -Pz
...
This is desired behavior of GNU grep version 2.24 (released on March 10 2016) and above, and that's the fix for the bug which was introduced in GNU grep 2.5.
...
*_
https://unix.stackexchange.com/questions/324263/grep-command-doesnt-support-start-and-end-of-line-anchors-when-its-wit
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22655#47
Though it's a GNU grep issue there's the need for adjusting grep condition to circumstances.
Attachments
Issue Links
- is duplicated by
-
-
- Closed
-
- is part of
-
-
- Closed
-
- links to
Activity
The line could be updated to:
if [ -f `my_print_defaults --mysqld | grep -m 1 -oP "pid-file=\K.+$"` ]; then |
That's what the Debian packages use right now.
Or since pid files aren't actually needed in the configuration:
if systemctl -q is-active mariadb; then
|
The fix implemented in Debian is not a proper solution, as the process will use the latest definition of a variable. So the 1st instance in /etc/mysql/my.cnf will be overwritten with the second instance in /etc/mysql/mariadb.conf.d/50-server.cnf. Or, potentially in other custom definitions of the variable.
It is better to use:
if [ -f $(my_print_defaults --mysqld | grep -m1 -oP "pid-file=\K[^$]+") | tail -n1 ]; then |
Superseded by https://github.com/MariaDB/server/pull/1556 and MDEV-22659.
Given the amount of use of my_print_defaults to extract specific server settings perhaps it is my_print_defaults that needs an interface change to return a subset of values only rather than predictable but necessary grep pipelines.