-
Task
-
-
Major
-
Resolution:
Fixed
-
-
-
resolve_const_item() is not friendly to pluggable data types, as it has:
- A switch on the result of item_cmp_type()
- A call for field_type_for_temporal_comparison()
This is hard-coded for built-in data types only and won't work properly for new data types.
We'll do the following:
- Introduce a new method in Type_handler:
virtual Item *make_const_item_for_comparison(THD *thd,
|
Item *src,
|
Item *comparand) const= 0;
|
- Split the code in resolve_const_item() into virtual implementations of the proper type handler implementations
- Replace item_cmp_type() to Type_handler_hybrid_field_type::aggregate_for_comparison()
- Remove Item::field_type_for_temporal_comparison(), as it won't be used any more in the server code.
- blocks
-
MDEV-4912
Data type plugin API version 1
-
-
Closed
Alexander Barkov
made changes -
issue.field.resolutiondate
|
2017-05-05 20:04:56.0
|
2017-05-05 20:04:56.777
|
Alexander Barkov
made changes -
Fix Version/s
|
|
10.3.1
[ 22532
]
|
Fix Version/s
|
10.3
[ 22126
]
|
|
Resolution
|
|
Fixed
[ 1
]
|
Status
|
Open
[ 1
]
|
Closed
[ 6
]
|
Sergei Golubchik
made changes -
Workflow
|
MariaDB v3
[ 80628
]
|
MariaDB v4
[ 133236
]
|
{"report":{"fcp":1650.2999999523163,"ttfb":393.2999999523163,"pageVisibility":"visible","entityId":61218,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"7293370a-8f7d-46c6-b35f-99cd4131dcab","navigationType":0,"readyForUser":1721.6999998092651,"redirectCount":0,"resourceLoadedEnd":1390.1999998092651,"resourceLoadedStart":398.09999990463257,"resourceTiming":[{"duration":716.4000000953674,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":398.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":398.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1114.5,"responseStart":0,"secureConnectionStart":0},{"duration":716.4000000953674,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":398.39999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":398.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1114.7999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":725.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":398.59999990463257,"connectEnd":398.59999990463257,"connectStart":398.59999990463257,"domainLookupEnd":398.59999990463257,"domainLookupStart":398.59999990463257,"fetchStart":398.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":398.59999990463257,"responseEnd":1124,"responseStart":1124,"secureConnectionStart":398.59999990463257},{"duration":858.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":398.69999980926514,"connectEnd":398.69999980926514,"connectStart":398.69999980926514,"domainLookupEnd":398.69999980926514,"domainLookupStart":398.69999980926514,"fetchStart":398.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":398.69999980926514,"responseEnd":1257.1999998092651,"responseStart":1257.1999998092651,"secureConnectionStart":398.69999980926514},{"duration":862.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":399,"connectEnd":399,"connectStart":399,"domainLookupEnd":399,"domainLookupStart":399,"fetchStart":399,"redirectEnd":0,"redirectStart":0,"requestStart":399,"responseEnd":1261.1999998092651,"responseStart":1261.1999998092651,"secureConnectionStart":399},{"duration":862.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":399.09999990463257,"connectEnd":399.09999990463257,"connectStart":399.09999990463257,"domainLookupEnd":399.09999990463257,"domainLookupStart":399.09999990463257,"fetchStart":399.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":399.09999990463257,"responseEnd":1261.5,"responseStart":1261.5,"secureConnectionStart":399.09999990463257},{"duration":862.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":399.2999999523163,"connectEnd":399.2999999523163,"connectStart":399.2999999523163,"domainLookupEnd":399.2999999523163,"domainLookupStart":399.2999999523163,"fetchStart":399.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":399.2999999523163,"responseEnd":1262,"responseStart":1262,"secureConnectionStart":399.2999999523163},{"duration":868.7999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":399.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":399.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1268.2999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":862.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":399.69999980926514,"connectEnd":399.69999980926514,"connectStart":399.69999980926514,"domainLookupEnd":399.69999980926514,"domainLookupStart":399.69999980926514,"fetchStart":399.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":399.69999980926514,"responseEnd":1262.3999998569489,"responseStart":1262.3999998569489,"secureConnectionStart":399.69999980926514},{"duration":868.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":399.89999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":399.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1268.3999998569489,"responseStart":0,"secureConnectionStart":0},{"duration":862.8000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":400.19999980926514,"connectEnd":400.19999980926514,"connectStart":400.19999980926514,"domainLookupEnd":400.19999980926514,"domainLookupStart":400.19999980926514,"fetchStart":400.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":400.19999980926514,"responseEnd":1263,"responseStart":1263,"secureConnectionStart":400.19999980926514},{"duration":911.8000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":411.69999980926514,"connectEnd":411.69999980926514,"connectStart":411.69999980926514,"domainLookupEnd":411.69999980926514,"domainLookupStart":411.69999980926514,"fetchStart":411.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":411.69999980926514,"responseEnd":1323.5,"responseStart":1323.5,"secureConnectionStart":411.69999980926514},{"duration":971.6999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":418.5,"connectEnd":418.5,"connectStart":418.5,"domainLookupEnd":418.5,"domainLookupStart":418.5,"fetchStart":418.5,"redirectEnd":0,"redirectStart":0,"requestStart":418.5,"responseEnd":1390.1999998092651,"responseStart":1390.1999998092651,"secureConnectionStart":418.5},{"duration":75.40000009536743,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1280.5999999046326,"connectEnd":1280.5999999046326,"connectStart":1280.5999999046326,"domainLookupEnd":1280.5999999046326,"domainLookupStart":1280.5999999046326,"fetchStart":1280.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":1280.5999999046326,"responseEnd":1356,"responseStart":1356,"secureConnectionStart":1280.5999999046326}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":224,"responseStart":393,"responseEnd":418,"domLoading":396,"domInteractive":1777,"domContentLoadedEventStart":1777,"domContentLoadedEventEnd":1825,"domComplete":2232,"loadEventStart":2232,"loadEventEnd":2233,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1753.5},{"name":"bigPipe.sidebar-id.end","time":1754.3999998569489},{"name":"bigPipe.activity-panel-pipe-id.start","time":1754.5999999046326},{"name":"bigPipe.activity-panel-pipe-id.end","time":1756.6999998092651},{"name":"activityTabFullyLoaded","time":1843.0999999046326}],"measures":[],"correlationId":"cbc332c4331268","effectiveType":"4g","downlink":9.3,"rtt":0,"serverDuration":110,"dbReadsTimeInMs":15,"dbConnsTimeInMs":23,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}