Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12678

MariaDB 10.3.0 fails to build on mips and mipsel due missing atomic ops implementation

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Won't Fix
    • 10.3.0
    • N/A
    • Compiling
    • 10.3.1-1

    Description

      MariaDB 10.3.0 fails to build from source due:

      In file included from ../include/lf.h:19:0,
                       from /«PKGBUILDDIR»/mysys/lf_alloc-pin.c:104:
      ../include/my_atomic.h:121:2: error: #error atomic ops for this platform are not implemented
       #error atomic ops for this platform are not implemented
        ^~~~~
      ../include/my_atomic.h: In function 'my_atomic_cas32':
      ../include/my_atomic.h:154:3: warning: implicit declaration of function 'make_atomic_cas_body' [-Wimplicit-function-declaration]
         make_atomic_cas_body(S);                                      \
         ^
      ../include/my_atomic.h:189:1: note: in expansion of macro 'make_atomic_cas'
       make_atomic_cas(32)
       ^~~~~~~~~~~~~~~
      ../include/my_atomic.h: In function 'my_atomic_casptr':
      ../include/my_atomic.h:191:17: error: 'ptr' undeclared (first use in this function)
       make_atomic_cas(ptr)
                       ^
      ../include/my_atomic.h:154:24: note: in definition of macro 'make_atomic_cas'
         make_atomic_cas_body(S);                                      \
                              ^
      ../include/my_atomic.h:191:17: note: each undeclared identifier is reported only once for each function it appears in
       make_atomic_cas(ptr)
                       ^
      ../include/my_atomic.h:154:24: note: in definition of macro 'make_atomic_cas'
         make_atomic_cas_body(S);                                      \
                              ^
      

      mips and mipsel are Debian release architectures, so this needs to be supported.

      Full build log are attached.

      Attachments

        Issue Links

          Activity

            danblack Daniel Black added a comment -

            10.4 no longer includes the error and was large factored to use standard atomics.

            We don't have to support it just because mips(es) are a Debian supported architecture. Supporting post-release architecutre without a pre-release CI on that same architectures isn't a workable model.

            danblack Daniel Black added a comment - 10.4 no longer includes the error and was large factored to use standard atomics. We don't have to support it just because mips(es) are a Debian supported architecture. Supporting post-release architecutre without a pre-release CI on that same architectures isn't a workable model.

            People

              cvicentiu Vicențiu Ciorbaru
              oerdnj Ondřej Surý (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.