[MDEV-12678] MariaDB 10.3.0 fails to build on mips and mipsel due missing atomic ops implementation Created: 2017-05-04  Updated: 2021-10-29  Resolved: 2021-10-29

Status: Closed
Project: MariaDB Server
Component/s: Compiling
Affects Version/s: 10.3.0
Fix Version/s: N/A

Type: Bug Priority: Major
Reporter: Ondřej Surý (Inactive) Assignee: Vicențiu Ciorbaru
Resolution: Won't Fix Votes: 0
Labels: not-10.4

Attachments: Text File mariadb-10.3_10.3.0-0~exp2_mips.txt     Text File mariadb-10.3_10.3.0-0~exp2_mipsel.txt    
Issue Links:
Relates
relates to MDEV-13656 10.3 does not build on CentOS 5 x86 (... Closed
Sprint: 10.3.1-1

 Description   

MariaDB 10.3.0 fails to build from source due:

In file included from ../include/lf.h:19:0,
                 from /«PKGBUILDDIR»/mysys/lf_alloc-pin.c:104:
../include/my_atomic.h:121:2: error: #error atomic ops for this platform are not implemented
 #error atomic ops for this platform are not implemented
  ^~~~~
../include/my_atomic.h: In function 'my_atomic_cas32':
../include/my_atomic.h:154:3: warning: implicit declaration of function 'make_atomic_cas_body' [-Wimplicit-function-declaration]
   make_atomic_cas_body(S);                                      \
   ^
../include/my_atomic.h:189:1: note: in expansion of macro 'make_atomic_cas'
 make_atomic_cas(32)
 ^~~~~~~~~~~~~~~
../include/my_atomic.h: In function 'my_atomic_casptr':
../include/my_atomic.h:191:17: error: 'ptr' undeclared (first use in this function)
 make_atomic_cas(ptr)
                 ^
../include/my_atomic.h:154:24: note: in definition of macro 'make_atomic_cas'
   make_atomic_cas_body(S);                                      \
                        ^
../include/my_atomic.h:191:17: note: each undeclared identifier is reported only once for each function it appears in
 make_atomic_cas(ptr)
                 ^
../include/my_atomic.h:154:24: note: in definition of macro 'make_atomic_cas'
   make_atomic_cas_body(S);                                      \
                        ^

mips and mipsel are Debian release architectures, so this needs to be supported.

Full build log are attached.



 Comments   
Comment by Daniel Black [ 2021-10-29 ]

10.4 no longer includes the error and was large factored to use standard atomics.

We don't have to support it just because mips(es) are a Debian supported architecture. Supporting post-release architecutre without a pre-release CI on that same architectures isn't a workable model.

Generated at Thu Feb 08 07:59:35 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.