Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12602

InnoDB: Failing assertion: space->n_pending_ops == 0

Details

    Description

      When a tablespace is being removed from the InnoDB tablespace cache, we occasionally have an assertion failing in 10.2:

      2017-04-27 10:38:42 0x4538  InnoDB: Assertion failure in file D:\win32-debug\build\src\storage\innobase\fil\fil0fil.cc line 2875
      InnoDB: Failing assertion: space->n_pending_ops == 0
      

      This has failed at least twice in 10.2:
      non-debug x86, Debian Stretch
      debug x86, Microsoft Windows

      The likely cause is the MDEV-12428 fix, which allows I/O threads to increment the fil_space_t::n_pending_ops count even after the tablespace has been marked for dropping.

      We must review the code also in 10.1 before the 10.1.23 release.

      Attachments

        Issue Links

          Activity

            marko Marko Mäkelä created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            Status Open [ 1 ] In Progress [ 3 ]

            bb-10.2-marko
            I think that we need this patch also in the 10.1.23 release. For that, we must backport the two-phase freeing of fil_space_t (fil_space_detach(), fil_space_free_low()) from 10.2.

            marko Marko Mäkelä added a comment - bb-10.2-marko I think that we need this patch also in the 10.1.23 release. For that, we must backport the two-phase freeing of fil_space_t (fil_space_detach(), fil_space_free_low()) from 10.2.
            marko Marko Mäkelä made changes -
            Assignee Marko Mäkelä [ marko ] Jan Lindström [ jplindst ]
            Status In Progress [ 3 ] In Review [ 10002 ]

            ok to push even without considering my comments, they were just stylistic, technically this patch is correct.

            jplindst Jan Lindström (Inactive) added a comment - ok to push even without considering my comments, they were just stylistic, technically this patch is correct.
            jplindst Jan Lindström (Inactive) made changes -
            Assignee Jan Lindström [ jplindst ] Marko Mäkelä [ marko ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            marko Marko Mäkelä made changes -
            Assignee Marko Mäkelä [ marko ] Jan Lindström [ jplindst ]
            Status Stalled [ 10000 ] In Review [ 10002 ]

            ok to push.

            jplindst Jan Lindström (Inactive) added a comment - ok to push.
            jplindst Jan Lindström (Inactive) made changes -
            Status In Review [ 10002 ] Stalled [ 10000 ]
            jplindst Jan Lindström (Inactive) made changes -
            Assignee Jan Lindström [ jplindst ] Marko Mäkelä [ marko ]
            marko Marko Mäkelä made changes -
            issue.field.resolutiondate 2017-04-28 14:16:22.0 2017-04-28 14:16:22.069
            marko Marko Mäkelä made changes -
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 80489 ] MariaDB v4 [ 152024 ]

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.