[MDEV-12602] InnoDB: Failing assertion: space->n_pending_ops == 0 Created: 2017-04-27  Updated: 2020-01-24  Resolved: 2017-04-28

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - InnoDB
Affects Version/s: 10.1.23, 10.2.6
Fix Version/s: 10.1.23, 10.2.6

Type: Bug Priority: Blocker
Reporter: Marko Mäkelä Assignee: Marko Mäkelä
Resolution: Fixed Votes: 0
Labels: 10.2-ga, crash, encryption

Issue Links:
Relates
relates to MDEV-11581 Mariadb starts innodb encryption thre... Closed
relates to MDEV-11738 Mariadb uses 100% of several of my 8 ... Closed
relates to MDEV-11929 During delete: InnoDB: Assertion fail... Closed
relates to MDEV-12253 Buffer pool blocks are accessed after... Closed
relates to MDEV-12396 MariaDB Server SEGV crash when import... Closed
relates to MDEV-12428 SIGSEGV in buf_page_decrypt_after_rea... Closed
relates to MDEV-12637 main.range_vs_index_merge_innodb fail... Closed
relates to MDEV-12694 test failure: encryption.create_or_re... Closed
relates to MDEV-12898 encryption.innodb-redo-badkey failed ... Closed

 Description   

When a tablespace is being removed from the InnoDB tablespace cache, we occasionally have an assertion failing in 10.2:

2017-04-27 10:38:42 0x4538  InnoDB: Assertion failure in file D:\win32-debug\build\src\storage\innobase\fil\fil0fil.cc line 2875
 
InnoDB: Failing assertion: space->n_pending_ops == 0

This has failed at least twice in 10.2:
non-debug x86, Debian Stretch
debug x86, Microsoft Windows

The likely cause is the MDEV-12428 fix, which allows I/O threads to increment the fil_space_t::n_pending_ops count even after the tablespace has been marked for dropping.

We must review the code also in 10.1 before the 10.1.23 release.

 Comments   
Comment by Marko Mäkelä [ 2017-04-28 ]

bb-10.2-marko
I think that we need this patch also in the 10.1.23 release. For that, we must backport the two-phase freeing of fil_space_t (fil_space_detach(), fil_space_free_low()) from 10.2.

Comment by Jan Lindström (Inactive) [ 2017-04-28 ]

ok to push even without considering my comments, they were just stylistic, technically this patch is correct.

Comment by Marko Mäkelä [ 2017-04-28 ]

bb-10.1-marko

Comment by Jan Lindström (Inactive) [ 2017-04-28 ]

ok to push.

Generated at Thu Feb 08 07:59:00 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.