Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12419

IMPORT should not look up tablespace in PageConverter::validate()

    Details

      Description

      MDEV-11759 added a tablespace lookup to PageConverter::validate(), based on the contents of the page. This does not seem to make any sense. When InnoDB is importing a tablespace, the tablespace ID that is being used in the file may or may not be in use by existing tables in the server instance. If the ID is not used, the lookup would always return NULL. If a tablespace by that ID happens to exist, then we could be in deep trouble, because we are invoking buf_page_is_corrupted() with a completely bogus tablespace.

      Please add a proper IMPORT test for page_compression and encryption.

      In 10.2, please remove the function fil_space_found_by_id() altogether. Like fil_space_get(), it is unsafe to use, because the pointer can be stale if the tablespace was dropped just after the call.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jplindst Jan Lindström
                Reporter:
                marko Marko Mäkelä
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: