Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12358

GCC 7 issues

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.1.22
    • 10.1.24
    • Compiling, Server, Tests
    • None
    • Fedora 25

    Description

      Hello,
      I created this bug as a tracker of various issues, that emerged from use of GCC 7 instead of GCC 6.3

      1) I wanted to use debug build, but it FTBFS because of compile time error.

      error: 'fts_ast_node_type_get' was not declared in this scope

      and simmilar, the build log can be found here

      2) When built with GCC7, about 120 new tests start to fail.

      To check, if it is caused by GCC, I made 2 containers in which I tried to get as close to Fedora Koji build system machines, as possible. Those 2 containers then differ only in version of GCC and its dependecies.

      I attached list of packages, build logs and lists of failing tests from both containers.

      • files with '_gcc' are after GCC7 upgrade
      • failing tests list from 'fail_docker_25' are long term failing, I don't need to solve them now.

      The source RPM, that I rebuilt, can be found here

      Attachments

        1. fail_docker_25
          0.5 kB
          Michal Schorm
        2. fail_docker_25_gcc
          7 kB
          Michal Schorm
        3. log_docker_25
          5.69 MB
          Michal Schorm
        4. log_docker_25_gcc
          7.54 MB
          Michal Schorm
        5. pkgs_docker_25
          8 kB
          Michal Schorm
        6. pkgs_docker_25_gcc
          8 kB
          Michal Schorm

        Issue Links

          includes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12888 Remove unused field dict_index_t::is_ngram

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12824 GCC 7 warning: this statement may fall through [-Wimplicit-fallthrough=]

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 21 older comments
            marko Marko Mäkelä added a comment -

            mschorm, I pushed a merge to 10.1. It does not fix the my_config.h issue yet; that you should be able to work around by adding

            #include "my_config.h"

            to the start of the affected files.

            marko Marko Mäkelä added a comment - mschorm , I pushed a merge to 10.1. It does not fix the my_config.h issue yet; that you should be able to work around by adding #include "my_config.h" to the start of the affected files.
            marko Marko Mäkelä added a comment -

            I pushed a merge to 10.2 as well.

            marko Marko Mäkelä added a comment - I pushed a merge to 10.2 as well.
            mschorm Michal Schorm added a comment -

            I tried to build MariaDB on Fedora from the commit in this comment Marko.
            And it looks like the issue with hundreds test failing has been solved.

            Great work!

            mschorm Michal Schorm added a comment - I tried to build MariaDB on Fedora from the commit in this comment Marko. And it looks like the issue with hundreds test failing has been solved. Great work!
            mschorm Michal Schorm added a comment -

            MariaDB 10.1.24 is now in stable repos in Fedora.
            The GCC issue looks resolved - good job!

            However, I'm still not able to make a debug build. But that is different issue, so I should probabbly create a new JIRA ticket - shouldn't I?

            mschorm Michal Schorm added a comment - MariaDB 10.1.24 is now in stable repos in Fedora. The GCC issue looks resolved - good job! However, I'm still not able to make a debug build. But that is different issue, so I should probabbly create a new JIRA ticket - shouldn't I?
            danblack Daniel Black added a comment -

            Yeh, I'd do a new ticket. You seem comfortable that all gcc-7 issues raised here been resolved.

            Regarding debug builds look at MDEV-4646 as this introduces a CMake based RPM build of debug symbol packages.

            danblack Daniel Black added a comment - Yeh, I'd do a new ticket. You seem comfortable that all gcc-7 issues raised here been resolved. Regarding debug builds look at MDEV-4646 as this introduces a CMake based RPM build of debug symbol packages.

            People

              marko Marko Mäkelä
              mschorm Michal Schorm
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.