[MDEV-12088] sql_mode=ORACLE: Do not require BEGIN..END in multi-statement exception handlers in THEN clause - Jira

Details

Type: Technical task
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 10.3.0
Component/s: Parser, Stored routines
Labels:
- Compatibility

Sprint:
10.2.2-3, 10.2.2-1, 10.2.2-2, 10.2.2-4, 10.1.18

Description

When running with sql_mode=ORACLE, MariaDB (the bb-10.2-compatibility branch) requires extra BEGIN..END in multi-statement exception handlers in THEN clause:

SET sql_mode=ORACLE;

DROP PROCEDURE p1;

DELIMITER /

CREATE PROCEDURE p1 AS

BEGIN

  INSERT INTO t1 (a) VALUES (10);

EXCEPTION

  WHEN DUP_VAL_ON_INDEX THEN

  BEGIN

    NULL;

    NULL;

  END;

  WHEN OTHERS THEN

  BEGIN

    NULL;

    NULL;

  END;

END;

DELIMITER ;

For better Oracle compatibility, we'll fix it not to require BEGIN..END, to make this work:

SET sql_mode=ORACLE;

DROP PROCEDURE p1;

DELIMITER /

CREATE PROCEDURE p1 AS

BEGIN

  INSERT INTO t1 (a) VALUES (10);

EXCEPTION

  WHEN DUP_VAL_ON_INDEX THEN

    NULL;

    NULL;

  WHEN OTHERS THEN

    NULL;

    NULL;

END;

DELIMITER ;

Attachments

Activity

Alexander Barkov added a comment - 2017-02-20 15:51

Pushed into 10.3.0.

Alexander Barkov added a comment - 2017-02-20 15:51 Pushed into 10.3.0.

People

Assignee:: Alexander Barkov

Reporter:: Alexander Barkov

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 2017-02-20 10:00

Updated:: 2020-08-27 07:12

Resolved:: 2017-02-20 15:51

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server