Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12072

Do not unnecessarily construct rec_printer objects in debug builds

Details

    Description

      I introduced the rec_printer object in MySQL to pretty-print raw InnoDB records and index tuples in diagnostic messages. These objects are being constructed unconditionally, even though the DBUG_PRINT is not enabled.

      The unnecessary work would be avoided by simply passing rec_printer(…).str() to the DBUG_LOG that was introduced in MDEV-11713.

      Attachments

        Issue Links

          Activity

            f380e7b5535 MDEV-12072 Do not unnecessarily construct rec_printer objects in debug builds
            For some reason,

            ./mtr --mysqld=--debug=d,ib_merge_sort

            did not enable any output in the tests that I tried. I successfully tested this with

            ./mtr --mysqld=--debug=d,ib_cur

            marko Marko Mäkelä added a comment - f380e7b5535 MDEV-12072 Do not unnecessarily construct rec_printer objects in debug builds For some reason, ./mtr --mysqld=--debug=d,ib_merge_sort did not enable any output in the tests that I tried. I successfully tested this with ./mtr --mysqld=--debug=d,ib_cur

            ok to push

            jplindst Jan Lindström (Inactive) added a comment - ok to push

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.