[MDEV-12072] Do not unnecessarily construct rec_printer objects in debug builds Created: 2017-02-15 Updated: 2017-02-16 Resolved: 2017-02-16 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - InnoDB |
| Affects Version/s: | None |
| Fix Version/s: | 10.2.4 |
| Type: | Bug | Priority: | Major |
| Reporter: | Marko Mäkelä | Assignee: | Marko Mäkelä |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||
| Description |
|
I introduced the rec_printer object in MySQL to pretty-print raw InnoDB records and index tuples in diagnostic messages. These objects are being constructed unconditionally, even though the DBUG_PRINT is not enabled. The unnecessary work would be avoided by simply passing rec_printer(…).str() to the DBUG_LOG that was introduced in |
| Comments |
| Comment by Marko Mäkelä [ 2017-02-15 ] | ||
|
f380e7b5535 MDEV-12072 Do not unnecessarily construct rec_printer objects in debug builds
did not enable any output in the tests that I tried. I successfully tested this with
| ||
| Comment by Jan Lindström (Inactive) [ 2017-02-15 ] | ||
|
ok to push |