Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-11713

Optimize DBUG_PRINT and introduce DBUG_LOG

Details

    Description

      MariaDB Server is unnecessarily evaluating the arguments of DBUG_PRINT() macros when the label is not defined.

      The macro DBUG_LOG() for C++ operator<< output which was added for InnoDB diagnostics in MySQL 5.7 is missing from MariaDB. Unlike the MySQL 5.7 implementation, MariaDB will avoid allocating and initializing the output string when the label is not defined.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12072 Do not unnecessarily construct rec_printer objects in debug builds

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-11684 post-10.1-merge fixes

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            marko Marko Mäkelä created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            marko Marko Mäkelä made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            marko Marko Mäkelä made changes -
            Description MariaDB Server is unnecessarily evaluating the arguments of DBUG_PRINT() macros when the label is not defined.

            The macro DBUG_OUT() for C++ operator<< output which was added for InnoDB diagnostics in MySQL 5.7 is missing from MariaDB. Unlike the MySQL 5.7 implementation, MariaDB should avoid allocating and initializing the output string when the label is not defined.             		MariaDB Server is unnecessarily evaluating the arguments of DBUG_PRINT() macros when the label is not defined.

            The macro DBUG_LOG() for C++ operator<< output which was added for InnoDB diagnostics in MySQL 5.7 is missing from MariaDB. Unlike the MySQL 5.7 implementation, MariaDB will avoid allocating and initializing the output string when the label is not defined.
            marko Marko Mäkelä made changes -
            Assignee Marko Mäkelä [ marko ] Jan Lindström [ jplindst ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            marko Marko Mäkelä added a comment -

            Please review the changes to dbug.c and my_dbug.h.

            marko Marko Mäkelä added a comment - Please review the changes to dbug.c and my_dbug.h.
            marko Marko Mäkelä made changes -
            Assignee Jan Lindström [ jplindst ] Sergei Golubchik [ serg ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.2.4 [ 22116 ]
            marko Marko Mäkelä made changes -
            Assignee Sergei Golubchik [ serg ] Jan Lindström [ jplindst ]
            jplindst Jan Lindström (Inactive) added a comment -

            ok to push InnoDB part, server part need review from ~serg

            jplindst Jan Lindström (Inactive) added a comment - ok to push InnoDB part, server part need review from ~serg
            jplindst Jan Lindström (Inactive) made changes -
            Assignee Jan Lindström [ jplindst ] Marko Mäkelä [ marko ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            marko Marko Mäkelä made changes -
            Fix Version/s 10.2.4 [ 22116 ]
            Fix Version/s 10.2 [ 14601 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            marko Marko Mäkelä made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 79058 ] MariaDB v4 [ 133087 ]

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.