[MDEV-11713] Optimize DBUG_PRINT and introduce DBUG_LOG Created: 2017-01-03 Updated: 2017-02-16 Resolved: 2017-01-05 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Server, Storage Engine - InnoDB |
| Fix Version/s: | 10.2.4 |
| Type: | Task | Priority: | Major |
| Reporter: | Marko Mäkelä | Assignee: | Marko Mäkelä |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||
| Description |
|
MariaDB Server is unnecessarily evaluating the arguments of DBUG_PRINT() macros when the label is not defined. The macro DBUG_LOG() for C++ operator<< output which was added for InnoDB diagnostics in MySQL 5.7 is missing from MariaDB. Unlike the MySQL 5.7 implementation, MariaDB will avoid allocating and initializing the output string when the label is not defined. |
| Comments |
| Comment by Marko Mäkelä [ 2017-01-03 ] |
|
Please review the changes to dbug.c and my_dbug.h. |
| Comment by Jan Lindström (Inactive) [ 2017-01-05 ] |
|
ok to push InnoDB part, server part need review from ~serg |