Type:
Task
Priority:
Major
Resolution:
Fixed
This task will:
1. Introduce new Type_handler methods:
virtual in_vector *make_in_vector(THD *thd, const Item_func_in *func, uint nargs) const;
virtual bool Item_func_in_fix_comparator_compatible_types(THD *thd, Item_func_in *) const;
2. Remove these data type conditions in Item_func_in::fix_length_and_dec()
switch (m_comparator.cmp_type())
if (m_comparator.cmp_type() == STRING_RESULT
if (m_comparator.cmp_type() == ROW_RESULT)
if ... m_comparator.cmp_type() != INT_RESULT
and use the new Type_handler methods instead.
3. Split in_datetime (which now covers all temporal data types: DATETIME, DATE, TIME) into an abstract parent class in_temporal and two instantiable classes in_datetime (for DATETIME and DATE ) and in_time (for TIME ).
After this change the behavior of the code responsible for IN bisection search will be fully handled by Type_handler .
There will some explicit XXX_RESULT conditions be left though, in the code responsible for the cmp_items based IN search. This code will be cleaned-up in a separate patch.
blocks
MDEV-4912
Data type plugin API version 1
Closed
There are no comments yet on this issue.
{"report":{"fcp":796.5,"ttfb":175.09999990463257,"pageVisibility":"visible","entityId":59273,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"98eaa699-5931-4961-9005-2377c0c9365b","navigationType":0,"readyForUser":867,"redirectCount":0,"resourceLoadedEnd":518.0999999046326,"resourceLoadedStart":195.69999980926514,"resourceTiming":[{"duration":23,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":195.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":195.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":218.69999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":24.299999952316284,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":195.89999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":195.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":220.19999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":211.20000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":196.09999990463257,"connectEnd":196.09999990463257,"connectStart":196.09999990463257,"domainLookupEnd":196.09999990463257,"domainLookupStart":196.09999990463257,"fetchStart":196.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":222,"responseEnd":407.2999999523163,"responseStart":244.29999995231628,"secureConnectionStart":196.09999990463257},{"duration":321.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":196.69999980926514,"connectEnd":196.69999980926514,"connectStart":196.69999980926514,"domainLookupEnd":196.69999980926514,"domainLookupStart":196.69999980926514,"fetchStart":196.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":223.19999980926514,"responseEnd":518.0999999046326,"responseStart":247.69999980926514,"secureConnectionStart":196.69999980926514},{"duration":57.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":196.79999995231628,"connectEnd":196.79999995231628,"connectStart":196.79999995231628,"domainLookupEnd":196.79999995231628,"domainLookupStart":196.79999995231628,"fetchStart":196.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":227.79999995231628,"responseEnd":253.89999985694885,"responseStart":250.59999990463257,"secureConnectionStart":196.79999995231628},{"duration":62.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":197,"connectEnd":197,"connectStart":197,"domainLookupEnd":197,"domainLookupStart":197,"fetchStart":197,"redirectEnd":0,"redirectStart":0,"requestStart":230.29999995231628,"responseEnd":259.5,"responseStart":255.29999995231628,"secureConnectionStart":197},{"duration":62.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":197.09999990463257,"connectEnd":197.09999990463257,"connectStart":197.09999990463257,"domainLookupEnd":197.09999990463257,"domainLookupStart":197.09999990463257,"fetchStart":197.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":230.5,"responseEnd":259.69999980926514,"responseStart":256,"secureConnectionStart":197.09999990463257},{"duration":29.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":197.19999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":197.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":226.59999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":62.89999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":197.29999995231628,"connectEnd":197.29999995231628,"connectStart":197.29999995231628,"domainLookupEnd":197.29999995231628,"domainLookupStart":197.29999995231628,"fetchStart":197.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":230.79999995231628,"responseEnd":260.19999980926514,"responseStart":257.7999999523163,"secureConnectionStart":197.29999995231628},{"duration":29.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":197.39999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":197.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":227.29999995231628,"responseStart":0,"secureConnectionStart":0},{"duration":62.299999952316284,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":197.59999990463257,"connectEnd":197.59999990463257,"connectStart":197.59999990463257,"domainLookupEnd":197.59999990463257,"domainLookupStart":197.59999990463257,"fetchStart":197.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":230.89999985694885,"responseEnd":259.89999985694885,"responseStart":256.89999985694885,"secureConnectionStart":197.59999990463257},{"duration":317,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":198.89999985694885,"connectEnd":198.89999985694885,"connectStart":198.89999985694885,"domainLookupEnd":198.89999985694885,"domainLookupStart":198.89999985694885,"fetchStart":198.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":278,"responseEnd":515.8999998569489,"responseStart":506.59999990463257,"secureConnectionStart":198.89999985694885},{"duration":317.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":199.29999995231628,"connectEnd":199.29999995231628,"connectStart":199.29999995231628,"domainLookupEnd":199.29999995231628,"domainLookupStart":199.29999995231628,"fetchStart":199.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":306.5,"responseEnd":517,"responseStart":510.69999980926514,"secureConnectionStart":199.29999995231628},{"duration":129.90000009536743,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":554.6999998092651,"connectEnd":554.6999998092651,"connectStart":554.6999998092651,"domainLookupEnd":554.6999998092651,"domainLookupStart":554.6999998092651,"fetchStart":554.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":652,"responseEnd":684.5999999046326,"responseStart":683.5,"secureConnectionStart":554.6999998092651},{"duration":133.5,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":789.8999998569489,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":789.8999998569489,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":923.3999998569489,"responseStart":0,"secureConnectionStart":0},{"duration":161.90000009536743,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":796.3999998569489,"connectEnd":796.3999998569489,"connectStart":796.3999998569489,"domainLookupEnd":796.3999998569489,"domainLookupStart":796.3999998569489,"fetchStart":796.3999998569489,"redirectEnd":0,"redirectStart":0,"requestStart":928.6999998092651,"responseEnd":958.2999999523163,"responseStart":956.8999998569489,"secureConnectionStart":796.3999998569489}],"fetchStart":1,"domainLookupStart":1,"domainLookupEnd":1,"connectStart":1,"connectEnd":1,"requestStart":21,"responseStart":176,"responseEnd":200,"domLoading":179,"domInteractive":951,"domContentLoadedEventStart":951,"domContentLoadedEventEnd":994,"domComplete":1372,"loadEventStart":1372,"loadEventEnd":1372,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":935},{"name":"bigPipe.sidebar-id.end","time":935.6999998092651},{"name":"bigPipe.activity-panel-pipe-id.start","time":935.8999998569489},{"name":"bigPipe.activity-panel-pipe-id.end","time":936.3999998569489},{"name":"activityTabFullyLoaded","time":1006.1999998092651}],"measures":[],"correlationId":"d6158564b7c24e","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":85,"dbReadsTimeInMs":18,"dbConnsTimeInMs":27,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}