Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-11411

AliSQL: Fix issue #12: Compile TokuDB SE into embedded library failed

Details

    Description

      Two problems fixed in this patch:
      1. cmake regular expression can't compile for "stdc++";
      2. when create libmysqld.a archived library, object files of
         storage/tokudb/ft-index/src/loader.cc and
         storage/tokudb/ft-index/ft/loader/loader.cc conflicts,
         the former is overwrited, and lead to link failure finally.
      

      https://github.com/alibaba/AliSQL/commit/3d5891808c3e979bcde9e29ff4d4df462deed7f4

      Attachments

        Activity

          plinux, IIUC this can only happen if we link TokuDB statically. in MariaDB it is marked MODULE_ONLY, that is one cannot link it into the server statically. In AliSQL it is marked MANDATORY, that is always link statically.

          Marking TokuDB MANDATORY sounds a bit too strict for MariaDB (even InnoDB is not MANDATORY). But we could probably fix static compilation.

          Said the above, do you really need MANDATORY TokuDB in MariaDB?
          Do you really need statically linked TokuDB in MariaDB?

          svoj Sergey Vojtovich added a comment - plinux , IIUC this can only happen if we link TokuDB statically. in MariaDB it is marked MODULE_ONLY, that is one cannot link it into the server statically. In AliSQL it is marked MANDATORY, that is always link statically. Marking TokuDB MANDATORY sounds a bit too strict for MariaDB (even InnoDB is not MANDATORY). But we could probably fix static compilation. Said the above, do you really need MANDATORY TokuDB in MariaDB? Do you really need statically linked TokuDB in MariaDB?

          I'll keep this task open with goal to be able to compile TokuDB statically into embedded library.

          svoj Sergey Vojtovich added a comment - I'll keep this task open with goal to be able to compile TokuDB statically into embedded library.

          Doesn't seem to be relevant anymore according to plinux.

          svoj Sergey Vojtovich added a comment - Doesn't seem to be relevant anymore according to plinux .

          People

            svoj Sergey Vojtovich
            svoj Sergey Vojtovich
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.