[MDEV-11411] AliSQL: Fix issue #12: Compile TokuDB SE into embedded library failed Created: 2016-11-29  Updated: 2019-06-17  Resolved: 2019-06-17

Status: Closed
Project: MariaDB Server
Component/s: Embedded Server, Storage Engine - TokuDB
Fix Version/s: N/A

Type: Task Priority: Major
Reporter: Sergey Vojtovich Assignee: Sergey Vojtovich
Resolution: Won't Do Votes: 1
Labels: None

Epic Link: AliSQL patches

 Description    

Two problems fixed in this patch:
 
1. cmake regular expression can't compile for "stdc++";
 
2. when create libmysqld.a archived library, object files of
 
   storage/tokudb/ft-index/src/loader.cc and
 
   storage/tokudb/ft-index/ft/loader/loader.cc conflicts,
 
   the former is overwrited, and lead to link failure finally.

https://github.com/alibaba/AliSQL/commit/3d5891808c3e979bcde9e29ff4d4df462deed7f4

 Comments   
Comment by Sergey Vojtovich [ 2016-11-30 ]

plinux, IIUC this can only happen if we link TokuDB statically. in MariaDB it is marked MODULE_ONLY, that is one cannot link it into the server statically. In AliSQL it is marked MANDATORY, that is always link statically.

Marking TokuDB MANDATORY sounds a bit too strict for MariaDB (even InnoDB is not MANDATORY). But we could probably fix static compilation.

Said the above, do you really need MANDATORY TokuDB in MariaDB?
Do you really need statically linked TokuDB in MariaDB?

Comment by Sergey Vojtovich [ 2016-12-17 ]

I'll keep this task open with goal to be able to compile TokuDB statically into embedded library.

Comment by Sergey Vojtovich [ 2019-06-17 ]

Doesn't seem to be relevant anymore according to plinux.

Generated at Thu Feb 08 07:49:45 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.