-
Task
-
-
Major
-
Resolution:
Fixed
-
-
-
As a part of preparatory work for MDEV-4912, we'll add a new virtual method in Type_handler:
virtual Item_cache *Item_get_cache(THD *thd, const Item *item) const;
|
and split this code into implementations of the new virtual method:
Item_cache* Item_cache::get_cache(THD *thd, const Item *item,
|
const Item_result type)
|
{
|
MEM_ROOT *mem_root= thd->mem_root;
|
switch (type) {
|
case INT_RESULT:
|
return new (mem_root) Item_cache_int(thd, item->field_type());
|
case REAL_RESULT:
|
return new (mem_root) Item_cache_real(thd);
|
case DECIMAL_RESULT:
|
return new (mem_root) Item_cache_decimal(thd);
|
case STRING_RESULT:
|
return new (mem_root) Item_cache_str(thd, item);
|
case ROW_RESULT:
|
return new (mem_root) Item_cache_row(thd);
|
case TIME_RESULT:
|
return new (mem_root) Item_cache_temporal(thd, item->field_type());
|
}
|
return 0; // Impossible
|
}
|
This will allow data type plugins to create their own versions of Item_cache, to optimize comparison with constants.
- blocks
-
MDEV-4912
Data type plugin API version 1
-
-
Closed
{"report":{"fcp":640.7999999523163,"ttfb":154,"pageVisibility":"visible","entityId":59059,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"4d104caf-36f5-44dd-ba93-96b247445e7c","navigationType":0,"readyForUser":773.5999999046326,"redirectCount":0,"resourceLoadedEnd":700.5,"resourceLoadedStart":159.5,"resourceTiming":[{"duration":6.099999904632568,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":159.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":159.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":165.59999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":6.200000047683716,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":159.79999995231628,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":159.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":166,"responseStart":0,"secureConnectionStart":0},{"duration":78.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":159.89999985694885,"connectEnd":159.89999985694885,"connectStart":159.89999985694885,"domainLookupEnd":159.89999985694885,"domainLookupStart":159.89999985694885,"fetchStart":159.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":159.89999985694885,"responseEnd":238.79999995231628,"responseStart":238.79999995231628,"secureConnectionStart":159.89999985694885},{"duration":175.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":160,"connectEnd":160,"connectStart":160,"domainLookupEnd":160,"domainLookupStart":160,"fetchStart":160,"redirectEnd":0,"redirectStart":0,"requestStart":160,"responseEnd":335.19999980926514,"responseStart":335.19999980926514,"secureConnectionStart":160},{"duration":178.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":160.09999990463257,"connectEnd":160.09999990463257,"connectStart":160.09999990463257,"domainLookupEnd":160.09999990463257,"domainLookupStart":160.09999990463257,"fetchStart":160.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":160.09999990463257,"responseEnd":338.89999985694885,"responseStart":338.89999985694885,"secureConnectionStart":160.09999990463257},{"duration":179.20000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":160.09999990463257,"connectEnd":160.09999990463257,"connectStart":160.09999990463257,"domainLookupEnd":160.09999990463257,"domainLookupStart":160.09999990463257,"fetchStart":160.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":160.09999990463257,"responseEnd":339.2999999523163,"responseStart":339.2999999523163,"secureConnectionStart":160.09999990463257},{"duration":181.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":160.19999980926514,"connectEnd":160.19999980926514,"connectStart":160.19999980926514,"domainLookupEnd":160.19999980926514,"domainLookupStart":160.19999980926514,"fetchStart":160.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":160.19999980926514,"responseEnd":341.89999985694885,"responseStart":341.89999985694885,"secureConnectionStart":160.19999980926514},{"duration":182,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":160.39999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":160.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":342.39999985694885,"responseStart":0,"secureConnectionStart":0},{"duration":181.89999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":160.5,"connectEnd":160.5,"connectStart":160.5,"domainLookupEnd":160.5,"domainLookupStart":160.5,"fetchStart":160.5,"redirectEnd":0,"redirectStart":0,"requestStart":160.5,"responseEnd":342.39999985694885,"responseStart":342.39999985694885,"secureConnectionStart":160.5},{"duration":182.09999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":160.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":160.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":342.69999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":182.20000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":160.69999980926514,"connectEnd":160.69999980926514,"connectStart":160.69999980926514,"domainLookupEnd":160.69999980926514,"domainLookupStart":160.69999980926514,"fetchStart":160.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":160.69999980926514,"responseEnd":342.89999985694885,"responseStart":342.89999985694885,"secureConnectionStart":160.69999980926514},{"duration":457.39999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":161.5,"connectEnd":161.5,"connectStart":161.5,"domainLookupEnd":161.5,"domainLookupStart":161.5,"fetchStart":161.5,"redirectEnd":0,"redirectStart":0,"requestStart":161.5,"responseEnd":618.8999998569489,"responseStart":618.8999998569489,"secureConnectionStart":161.5},{"duration":475.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":161.5,"connectEnd":161.5,"connectStart":161.5,"domainLookupEnd":161.5,"domainLookupStart":161.5,"fetchStart":161.5,"redirectEnd":0,"redirectStart":0,"requestStart":161.5,"responseEnd":637.1999998092651,"responseStart":637.1999998092651,"secureConnectionStart":161.5},{"duration":228.79999995231628,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":390.39999985694885,"connectEnd":390.39999985694885,"connectStart":390.39999985694885,"domainLookupEnd":390.39999985694885,"domainLookupStart":390.39999985694885,"fetchStart":390.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":390.39999985694885,"responseEnd":619.1999998092651,"responseStart":619.1999998092651,"secureConnectionStart":390.39999985694885},{"duration":12.5,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":634.0999999046326,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":634.0999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":646.5999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":21.700000047683716,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":673.8999998569489,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":673.8999998569489,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":695.5999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":21.299999952316284,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":674.7999999523163,"connectEnd":674.7999999523163,"connectStart":674.7999999523163,"domainLookupEnd":674.7999999523163,"domainLookupStart":674.7999999523163,"fetchStart":674.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":674.7999999523163,"responseEnd":696.0999999046326,"responseStart":696.0999999046326,"secureConnectionStart":674.7999999523163},{"duration":25.300000190734863,"initiatorType":"script","name":"https://jira.mariadb.org/s/f51ef5507eea4c158f257c66c93b2a3f-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":675.1999998092651,"connectEnd":675.1999998092651,"connectStart":675.1999998092651,"domainLookupEnd":675.1999998092651,"domainLookupStart":675.1999998092651,"fetchStart":675.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":675.1999998092651,"responseEnd":700.5,"responseStart":700.5,"secureConnectionStart":675.1999998092651}],"fetchStart":1,"domainLookupStart":1,"domainLookupEnd":1,"connectStart":1,"connectEnd":1,"requestStart":15,"responseStart":155,"responseEnd":158,"domLoading":158,"domInteractive":839,"domContentLoadedEventStart":840,"domContentLoadedEventEnd":885,"domComplete":1803,"loadEventStart":1803,"loadEventEnd":1805,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":811.7999999523163},{"name":"bigPipe.sidebar-id.end","time":812.5999999046326},{"name":"bigPipe.activity-panel-pipe-id.start","time":812.6999998092651},{"name":"bigPipe.activity-panel-pipe-id.end","time":815.1999998092651},{"name":"activityTabFullyLoaded","time":896.1999998092651}],"measures":[],"correlationId":"d3827e0ec776bf","effectiveType":"4g","downlink":9.7,"rtt":0,"serverDuration":83,"dbReadsTimeInMs":11,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}