Type:
Task
Priority:
Major
Resolution:
Fixed
Item_func_hex::val_str_ascii() has a few tests on args[0] ->result_type() .
if (args[0]->result_type() == REAL_RESULT ||
args[0]->result_type() == DECIMAL_RESULT)
We'll move the data type specific code to the corresponding Type_handler_xxx , and rewrite Item_func_hex::val_str_ascii() to call a virtual method in Type_handler , e.g. about like this:
String *val_str_ascii(String *str)
{
return args[0]->type_handler()->Item_func_hex_val_str_ascii( this , str);
}
Note, the value of args[0] ->type_handler() can be cached at fix_length_and_dec() time, to have fewer virtual calls at run time:
String *val_str_ascii(String *str)
{
return m_handler->Item_func_hex_val_str_ascii( this , str);
}
blocks
MDEV-4912
Data type plugin API version 1
Closed
{"report":{"fcp":1917.5,"ttfb":322.10000014305115,"pageVisibility":"visible","entityId":58923,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"b2661d14-f1c1-4f5c-9f37-b390a78d2b3f","navigationType":0,"readyForUser":2002,"redirectCount":0,"resourceLoadedEnd":1604.3000001907349,"resourceLoadedStart":327.80000019073486,"resourceTiming":[{"duration":443.7999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":327.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":327.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":771.6000001430511,"responseStart":0,"secureConnectionStart":0},{"duration":443.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":328,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":328,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":771.9000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":1053.9000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":328.2000000476837,"connectEnd":328.2000000476837,"connectStart":328.2000000476837,"domainLookupEnd":328.2000000476837,"domainLookupStart":328.2000000476837,"fetchStart":328.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":821.7000000476837,"responseEnd":1382.1000001430511,"responseStart":854.8000001907349,"secureConnectionStart":328.2000000476837},{"duration":1275.9000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":328.40000009536743,"connectEnd":328.40000009536743,"connectStart":328.40000009536743,"domainLookupEnd":328.40000009536743,"domainLookupStart":328.40000009536743,"fetchStart":328.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":823.1000001430511,"responseEnd":1604.3000001907349,"responseStart":858.7000000476837,"secureConnectionStart":328.40000009536743},{"duration":562.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":328.5,"connectEnd":328.5,"connectStart":328.5,"domainLookupEnd":328.5,"domainLookupStart":328.5,"fetchStart":328.5,"redirectEnd":0,"redirectStart":0,"requestStart":823.4000000953674,"responseEnd":890.9000000953674,"responseStart":880.1000001430511,"secureConnectionStart":328.5},{"duration":563.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":328.7000000476837,"connectEnd":328.7000000476837,"connectStart":328.7000000476837,"domainLookupEnd":328.7000000476837,"domainLookupStart":328.7000000476837,"fetchStart":328.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":823.7000000476837,"responseEnd":892.1000001430511,"responseStart":881.9000000953674,"secureConnectionStart":328.7000000476837},{"duration":564.1000001430511,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":329,"connectEnd":329,"connectStart":329,"domainLookupEnd":329,"domainLookupStart":329,"fetchStart":329,"redirectEnd":0,"redirectStart":0,"requestStart":824.1000001430511,"responseEnd":893.1000001430511,"responseStart":885.6000001430511,"secureConnectionStart":329},{"duration":462.89999985694885,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":329.10000014305115,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":329.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":792,"responseStart":0,"secureConnectionStart":0},{"duration":567,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":329.30000019073486,"connectEnd":329.30000019073486,"connectStart":329.30000019073486,"domainLookupEnd":329.30000019073486,"domainLookupStart":329.30000019073486,"fetchStart":329.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":829.3000001907349,"responseEnd":896.3000001907349,"responseStart":894.3000001907349,"secureConnectionStart":329.30000019073486},{"duration":471.7000000476837,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":329.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":329.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":801.1000001430511,"responseStart":0,"secureConnectionStart":0},{"duration":568.1000001430511,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":329.5,"connectEnd":329.5,"connectStart":329.5,"domainLookupEnd":329.5,"domainLookupStart":329.5,"fetchStart":329.5,"redirectEnd":0,"redirectStart":0,"requestStart":829.6000001430511,"responseEnd":897.6000001430511,"responseStart":894.9000000953674,"secureConnectionStart":329.5},{"duration":1266.9000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":330.5,"connectEnd":330.5,"connectStart":330.5,"domainLookupEnd":330.5,"domainLookupStart":330.5,"fetchStart":330.5,"redirectEnd":0,"redirectStart":0,"requestStart":1043.2000000476837,"responseEnd":1597.4000000953674,"responseStart":1592.2000000476837,"secureConnectionStart":330.5},{"duration":1270.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":330.60000014305115,"connectEnd":330.60000014305115,"connectStart":330.60000014305115,"domainLookupEnd":330.60000014305115,"domainLookupStart":330.60000014305115,"fetchStart":330.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":1239.2000000476837,"responseEnd":1601.4000000953674,"responseStart":1597.6000001430511,"secureConnectionStart":330.60000014305115},{"duration":300.10000014305115,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1514.7000000476837,"connectEnd":1514.7000000476837,"connectStart":1514.7000000476837,"domainLookupEnd":1514.7000000476837,"domainLookupStart":1514.7000000476837,"fetchStart":1514.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":1779.3000001907349,"responseEnd":1814.8000001907349,"responseStart":1813.3000001907349,"secureConnectionStart":1514.7000000476837}],"fetchStart":0,"domainLookupStart":109,"domainLookupEnd":118,"connectStart":118,"connectEnd":138,"secureConnectionStart":126,"requestStart":139,"responseStart":322,"responseEnd":326,"domLoading":325,"domInteractive":2079,"domContentLoadedEventStart":2079,"domContentLoadedEventEnd":2144,"domComplete":2892,"loadEventStart":2893,"loadEventEnd":2893,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":2045.4000000953674},{"name":"bigPipe.sidebar-id.end","time":2046.4000000953674},{"name":"bigPipe.activity-panel-pipe-id.start","time":2046.7000000476837},{"name":"bigPipe.activity-panel-pipe-id.end","time":2050.7000000476837},{"name":"activityTabFullyLoaded","time":2157.800000190735}],"measures":[],"correlationId":"599e6ae90879c1","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":90,"dbReadsTimeInMs":9,"dbConnsTimeInMs":17,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}