Type:
Task
Priority:
Major
Resolution:
Fixed
Item_func_hex::val_str_ascii() has a few tests on args[0] ->result_type() .
if (args[0]->result_type() == REAL_RESULT ||
args[0]->result_type() == DECIMAL_RESULT)
We'll move the data type specific code to the corresponding Type_handler_xxx , and rewrite Item_func_hex::val_str_ascii() to call a virtual method in Type_handler , e.g. about like this:
String *val_str_ascii(String *str)
{
return args[0]->type_handler()->Item_func_hex_val_str_ascii( this , str);
}
Note, the value of args[0] ->type_handler() can be cached at fix_length_and_dec() time, to have fewer virtual calls at run time:
String *val_str_ascii(String *str)
{
return m_handler->Item_func_hex_val_str_ascii( this , str);
}
blocks
MDEV-4912
Data type plugin API version 1
Closed
There are no comments yet on this issue.
{"report":{"fcp":1251.3000001907349,"ttfb":187.2000002861023,"pageVisibility":"visible","entityId":58923,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"2125daec-71d1-4505-9103-eeb58c59663a","navigationType":0,"readyForUser":1330.9000000953674,"redirectCount":0,"resourceLoadedEnd":1863.5,"resourceLoadedStart":192.80000019073486,"resourceTiming":[{"duration":416.59999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":192.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":192.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":609.4000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":416.6000003814697,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":193.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":193.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":609.7000002861023,"responseStart":0,"secureConnectionStart":0},{"duration":425.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":193.30000019073486,"connectEnd":193.30000019073486,"connectStart":193.30000019073486,"domainLookupEnd":193.30000019073486,"domainLookupStart":193.30000019073486,"fetchStart":193.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":193.30000019073486,"responseEnd":619,"responseStart":619,"secureConnectionStart":193.30000019073486},{"duration":451.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":193.40000009536743,"connectEnd":193.40000009536743,"connectStart":193.40000009536743,"domainLookupEnd":193.40000009536743,"domainLookupStart":193.40000009536743,"fetchStart":193.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":193.40000009536743,"responseEnd":645.3000001907349,"responseStart":645.3000001907349,"secureConnectionStart":193.40000009536743},{"duration":455.7999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":193.7000002861023,"connectEnd":193.7000002861023,"connectStart":193.7000002861023,"domainLookupEnd":193.7000002861023,"domainLookupStart":193.7000002861023,"fetchStart":193.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":193.7000002861023,"responseEnd":649.5,"responseStart":649.5,"secureConnectionStart":193.7000002861023},{"duration":456.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":193.80000019073486,"connectEnd":193.80000019073486,"connectStart":193.80000019073486,"domainLookupEnd":193.80000019073486,"domainLookupStart":193.80000019073486,"fetchStart":193.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":193.80000019073486,"responseEnd":649.9000000953674,"responseStart":649.9000000953674,"secureConnectionStart":193.80000019073486},{"duration":456.2000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":194.09999990463257,"connectEnd":194.09999990463257,"connectStart":194.09999990463257,"domainLookupEnd":194.09999990463257,"domainLookupStart":194.09999990463257,"fetchStart":194.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":194.09999990463257,"responseEnd":650.3000001907349,"responseStart":650.3000001907349,"secureConnectionStart":194.09999990463257},{"duration":457.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":194.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":194.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":652.2000002861023,"responseStart":0,"secureConnectionStart":0},{"duration":456.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":194.40000009536743,"connectEnd":194.40000009536743,"connectStart":194.40000009536743,"domainLookupEnd":194.40000009536743,"domainLookupStart":194.40000009536743,"fetchStart":194.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":194.40000009536743,"responseEnd":650.8000001907349,"responseStart":650.8000001907349,"secureConnectionStart":194.40000009536743},{"duration":457.7000002861023,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":194.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":194.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":652.3000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":456.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":194.7000002861023,"connectEnd":194.7000002861023,"connectStart":194.7000002861023,"domainLookupEnd":194.7000002861023,"domainLookupStart":194.7000002861023,"fetchStart":194.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":194.7000002861023,"responseEnd":651.4000000953674,"responseStart":651.4000000953674,"secureConnectionStart":194.7000002861023},{"duration":662.5999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":201.90000009536743,"connectEnd":201.90000009536743,"connectStart":201.90000009536743,"domainLookupEnd":201.90000009536743,"domainLookupStart":201.90000009536743,"fetchStart":201.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":201.90000009536743,"responseEnd":864.5,"responseStart":864.5,"secureConnectionStart":201.90000009536743},{"duration":1661.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":202,"connectEnd":202,"connectStart":202,"domainLookupEnd":202,"domainLookupStart":202,"fetchStart":202,"redirectEnd":0,"redirectStart":0,"requestStart":202,"responseEnd":1863.5,"responseStart":1863.5,"secureConnectionStart":202},{"duration":908.5999999046326,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":946.7000002861023,"connectEnd":946.7000002861023,"connectStart":946.7000002861023,"domainLookupEnd":946.7000002861023,"domainLookupStart":946.7000002861023,"fetchStart":946.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":946.7000002861023,"responseEnd":1855.3000001907349,"responseStart":1855.3000001907349,"secureConnectionStart":946.7000002861023},{"duration":762.2999997138977,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1213.8000001907349,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1213.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1976.0999999046326,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":32,"responseStart":187,"responseEnd":194,"domLoading":191,"domInteractive":2004,"domContentLoadedEventStart":2004,"domContentLoadedEventEnd":2053,"domComplete":2716,"loadEventStart":2716,"loadEventEnd":2717,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1977.3000001907349},{"name":"bigPipe.sidebar-id.end","time":1986.8000001907349},{"name":"bigPipe.activity-panel-pipe-id.start","time":1986.9000000953674},{"name":"bigPipe.activity-panel-pipe-id.end","time":1987.5},{"name":"activityTabFullyLoaded","time":2059.0999999046326}],"measures":[],"correlationId":"7bdad5466e7fa9","effectiveType":"4g","downlink":9.3,"rtt":0,"serverDuration":94,"dbReadsTimeInMs":10,"dbConnsTimeInMs":20,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}